---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32133/
---
Review request for mesos and Ian Downes.
Bugs: mesos-2332
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32130/#review76677
---
Patch looks great!
Reviews applied: [32130]
All tests passed.
-
On March 13, 2015, 4:46 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/include/process/http.hpp, line 145
https://reviews.apache.org/r/31930/diff/1/?file=891209#file891209line145
Also explain that this is an in-memory single OS process pipe, and is
not backed by file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
---
(Updated March 17, 2015, 12:25 a.m.)
Review request for mesos.
Changes
On March 16, 2015, 3:40 p.m., Adam B wrote:
src/slave/slave.cpp, lines 2490-2491
https://reviews.apache.org/r/32130/diff/1/?file=896443#file896443line2490
Why not just use update.mutable_status() instead of making a copy of
the StatusUpdate object? We do this in several other
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32139/
---
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32140/
---
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs:
See https://builds.apache.org/job/mesos-reviewbot/4638/
--
[...truncated 261 lines...]
Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32133/#review76681
---
Patch looks great!
Reviews applied: [32133]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32130/#review76687
---
Ship it!
Ship It!
- Adam B
On March 16, 2015, 4:06 p.m.,
See https://builds.apache.org/job/mesos-reviewbot/4639/
--
[...truncated 305 lines...]
Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
---
(Updated March 17, 2015, 3:37 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review76706
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 17, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31265/#review76679
---
For consistency, I would still root for Allocator::create()
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
---
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31930/#review76690
---
Patch looks great!
Reviews applied: [31930]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32130/#review76694
---
Ship it!
Ship It!
- Niklas Nielsen
On March 16, 2015, 4:06
See https://builds.apache.org/job/mesos-reviewbot/4620/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32098/#review76553
---
Patch looks great!
Reviews applied: [32098]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32098/
---
Review request for mesos.
Bugs: MESOS-1872
See https://builds.apache.org/job/mesos-reviewbot/4619/
--
[...truncated 5648 lines...]
mesos-0.23.0 archives ready for distribution:
mesos-0.23.0.tar.gz
==
real11m43.633s
user66m26.559s
sys
On March 15, 2015, 9:03 a.m., Adam B wrote:
src/tests/master_tests.cpp, line 1928
https://reviews.apache.org/r/31539/diff/5/?file=894989#file894989line1928
Not yours, but could you help out our style update push and s/ //
in code next to your changes (not necessarily the entire
On March 15, 2015, 9:03 a.m., Adam B wrote:
src/tests/master_tests.cpp, line 2018
https://reviews.apache.org/r/31539/diff/5/?file=894989#file894989line2018
Do we even need to CreateSlaveFlags() here and elsewhere? If you're not
setting any non-default flag values or otherwise
filed https://issues.apache.org/jira/browse/MESOS-2499 to track this
On Sun, Mar 15, 2015 at 11:20 PM, Vinod Kone vinodk...@apache.org wrote:
Ah crap. You are right! Please file a JIRA. We should have a test for this.
On Sun, Mar 15, 2015 at 8:05 PM, James DeFelice james.defel...@gmail.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review76542
---
Patch looks great!
Reviews applied: [31539]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32098/
---
(Updated March 16, 2015, 12:49 p.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated March 16, 2015, 3:20 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
---
(Updated March 16, 2015, 4:13 p.m.)
Review request for mesos.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32108/#review76567
---
Bad patch!
Reviews applied: [32108]
Failed command: make -j3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32108/#review76569
---
Needs fixing. Does not seem to work for make dist-check yet.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32108/
---
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
---
(Updated March 16, 2015, 3:22 p.m.)
Review request for mesos.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
---
Review request for mesos.
Repository: mesos
Description
---
see summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
---
(Updated March 16, 2015, 3:10 p.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review76564
---
Patch looks great!
Reviews applied: [32105, 30931]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
---
(Updated March 16, 2015, 6:11 p.m.)
Review request for mesos.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32150/
---
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32150/
---
(Updated March 17, 2015, 4:03 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/
---
(Updated March 17, 2015, 4:10 a.m.)
Review request for mesos, Alexander
See https://builds.apache.org/job/mesos-reviewbot/4641/
--
[...truncated 261 lines...]
Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
---
(Updated March 17, 2015, 4:06 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32140/
---
(Updated March 17, 2015, 4:06 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32150/
---
(Updated March 17, 2015, 4:06 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/#review76712
---
Patch looks great!
Reviews applied: [32139, 32140, 32149, 32150,
See https://builds.apache.org/job/mesos-reviewbot/4640/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review76642
---
src/authentication/cram_md5/authenticator.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31986/#review76643
---
LGTM
- Isabel Jimenez
On March 13, 2015, 3:21 p.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31930/
---
(Updated March 16, 2015, 11:49 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/#review76657
---
Patch looks great!
Reviews applied: [32058]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32130/
---
(Updated March 16, 2015, 11:06 p.m.)
Review request for mesos, Niklas Nielsen
On March 13, 2015, 1:25 a.m., Joris Van Remoortere wrote:
Great comments, thank you Joris!
On March 13, 2015, 1:25 a.m., Joris Van Remoortere wrote:
3rdparty/libprocess/src/process.cpp, line 202
https://reviews.apache.org/r/31930/diff/1/?file=891211#file891211line202
Can you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76607
---
I am getting a build error on Mac OS X (let's get this fixed first
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review76602
---
Ship it!
On March 16, 2015, 6:52 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 589
https://reviews.apache.org/r/32105/diff/3/?file=896108#file896108line589
I think you need to `#include iosfwd`.
Sorry, you'll need the whole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324/#review76627
---
Patch looks great!
Reviews applied: [31324]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324/
---
(Updated March 16, 2015, 11:43 a.m.)
Review request for mesos, Benjamin
On Feb. 25, 2015, 10:54 p.m., Ben Mahler wrote:
src/common/type_utils.cpp, lines 203-205
https://reviews.apache.org/r/30931/diff/8/?file=873690#file873690line203
You're taking a logging::Flags but you're iterating over non-logging
flags (i.e. slave::Flags, master::Flags), that's
On Feb. 28, 2015, 3:35 a.m., Jay Buffington wrote:
src/slave/containerizer/mesos/launch.cpp, line 218
https://reviews.apache.org/r/31444/diff/1/?file=876502#file876502line218
This is pretty invasive.
Jie suggested doing a private bind mount of flags.chroot.get() in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/
---
(Updated March 16, 2015, 7:16 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32123/
---
(Updated March 16, 2015, 7:30 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32123/
---
Review request for mesos, Ian Downes and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32098/
---
(Updated March 16, 2015, 12:36 p.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76635
---
Patch looks great!
Reviews applied: [32008]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/
---
(Updated March 16, 2015, 8:02 p.m.)
Review request for mesos and Till
64 matches
Mail list logo