Re: RFC: update C++ style to require the "override" keyword

2018-07-08 Thread Benjamin Bannier
Hi James, > I’d like to propose that we update our style to require that the > “override” keyword always be used when overriding virtual functions > (including destructors). The proposed text is below. I’ll also prepare > a clang-tidy patch to update stout, libprocess and mesos globally. +1!

Behavior change for the cgroups mounts inside container

2018-07-08 Thread Qian Zhang
Hi Folks, Recently we did a behavior change for the cgroups mounts inside the containers launched by UCR in the ticket MESOS-8327 : For the container with its own rootfs, before the change, it will see all cgroups as the agent host, and after the

RFC: update C++ style to require the "override" keyword

2018-07-08 Thread James Peach
Hi all, I’d like to propose that we update our style to require that the “override” keyword always be used when overriding virtual functions (including destructors). The proposed text is below. I’ll also prepare a clang-tidy patch to update stout, libprocess and mesos globally. ---