Re: [Design Doc] Native Support for Prometheus Metrics

2017-09-11 Thread James Peach
> On Sep 9, 2017, at 5:29 AM, Benjamin Bannier > wrote: > > Hi James, > > I'd like to make a longer comment here to make it easier to discuss. > >> [...] >> >> Note the proposal to alter how Timer metrics are exposed in an incompatible >> way (I argue this is

Re: [Design Doc] Native Support for Prometheus Metrics

2017-09-09 Thread Benjamin Bannier
Hi James, I'd like to make a longer comment here to make it easier to discuss. > [...] > > Note the proposal to alter how Timer metrics are exposed in an incompatible > way (I argue this is OK because you can't really make use of these metrics > now). I am not sure I follow your argument

[Design Doc] Native Support for Prometheus Metrics

2017-09-08 Thread James Peach
Hi all, This document discussed a proposal to implement native support for Prometheus metrics in libprocess. Note the proposal to alter how Timer metrics are exposed in an incompatible way (I argue this is OK because you can't really make use of these metrics now). >