Re: [E] Re: Require GCC >= 4.9

2016-10-11 Thread Wood, Aaron
Okay, I can add some logic to use the appropriate flag depending on the compiler version. At least that way there is some sort of stack protection for either case. Thanks, Aaron On 10/11/16, 11:14 AM, "Joris Van Remoortere" wrote: >If the only win is the introduction of

Re: [E] Re: Require GCC >= 4.9

2016-10-11 Thread Joris Van Remoortere
If the only win is the introduction of that flag I would tend to agree with Evers. The last time we bumped the compiler versions Cody did an analysis of all the major platforms and the ability to attain one of the required compilers easily. If we want to pursue bumping the minor versions for

Re: [E] Re: Require GCC >= 4.9

2016-10-11 Thread Evers Benno
To be honest, I still think it's a pretty big pain to require a custom compiler for mesos. From a packagers perspective, I would have to decide if I should upload the PPA package to our repositories, backport gcc-4.9 myself, or just revert this patch in our build. It would also raise the barrier

Re: [E] Re: Require GCC >= 4.9

2016-10-10 Thread Wood, Aaron
Hi, -Wall and -Werror have been set on Mesos for quite some time now. It¹s only in libprocess and stout that they were never set. Good point about trusty not including gcc 4.9. Do you think it would be acceptable to instruct people to take it from the toolchain PPA?