Github user janisz commented on the issue:
https://github.com/apache/mesos/pull/233
@kwiatkk1 Thanks for the review. I applied your suggestions.
@bmahler Changed `Unknown` to `-`
Github user janisz commented on the issue:
https://github.com/apache/mesos/pull/233
@bmahler I added some colours.
![health](https://user-images.githubusercontent.com/1616386/30872583-dae2d992-a2ea-11e7-8693-17efcd8610fa.gif)
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/233
@janisz I noticed you updated the patch, is it ready for another review?
Would be great to keep the colors as you had before. I was just asking about
the approach used :)
Also can you add a
Github user janisz commented on the issue:
https://github.com/apache/mesos/pull/233
* [x] The global tasks table
* [x] The framework-specific task table (when clicking into a framework)
* [x] The executor-specific task table within an agent (when clicking into
an agent, then a
Github user Vish0007 commented on the issue:
https://github.com/apache/mesos/pull/233
@janisz sounds great.
---
Github user janisz commented on the issue:
https://github.com/apache/mesos/pull/233
@Vish0007 To create this screenshot I created 3 applications called
`unhealthy`, `healthy` and `unknown` so it's just a coincidence that the name
has the same value as tasks health. When I fix all
Github user Vish0007 commented on the issue:
https://github.com/apache/mesos/pull/233
@janisz the UI looks good and health check does add value.
would you describe how the "Task Name" and "Health" are different, i can
see health status in both places.
---
Github user janisz commented on the issue:
https://github.com/apache/mesos/pull/233
@bmahler Thanks for the review. Most of the issues are minor and easy to
fix. I do it shortly.
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/233
Thanks janisz, this looks pretty good. However, this needs to be added to
several places:
- The global tasks table (you covered this)
- The framework-specific task table (when clicking
Github user lilysamimi commented on the issue:
https://github.com/apache/mesos/pull/233
Would be interested in talking with the folks that created this UI
component. I'm giving out $10 Amazon gift cards to individuals who participate
in a user experience research study with me
10 matches
Mail list logo