Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/284
@bbannier , apparently apply-review.py retrieves data from the profile in
the review board. I updated my profile and now the author is correct (I mean
without accent).
Thank you for the help.
Github user bbannier commented on the issue:
https://github.com/apache/mesos/pull/284
@clems4ever I don't believe fixing that database is going to make
`support/apply_reviews.py` work. I think you need to reconfigure the name you
use to create git commit you put onto reviewboard --
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/284
@andschwa , no problem. Do you have the rights to merge it?
---
Github user andschwa commented on the issue:
https://github.com/apache/mesos/pull/284
@clems4ever Yes, and I'm sorry ð
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/284
Thank you guys for your feedbacks. Since it might take some time to rewrite
the script in Python 3 I think it's better to merge this PR so that I can move
forward with my review in the review
Github user gkleiman commented on the issue:
https://github.com/apache/mesos/pull/284
I also had to change my name from `Gastón` to `Gaston` to stop the Windows
reviewbot from failing to apply my patches.
---
Github user andschwa commented on the issue:
https://github.com/apache/mesos/pull/284
@bmahler Really the only fix is to convert our Python scripts to Python 3.
(I tried to get someone at the Hackathon to do this ð but failed ð¦).
---
Github user kaysoky commented on the issue:
https://github.com/apache/mesos/pull/284
Here's the associated JIRA: https://issues.apache.org/jira/browse/MESOS-7658
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/284
We should try to fix apply-reviews.py. Looks related to this discussion?
https://bugs.python.org/issue1759845
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/284
Apparently the character `\xe9` is `é` as stated here:
https://stackoverflow.com/questions/6327494/what-is-the-following-unicode-string-xe9.
So, I really think this is due to my first name.
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/284
@bmahler , here is the error:
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/284
@clems4ever can you post the error? Is this an issue in `rbt` or our python
wrapper script?
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/284
Hello @tillt , there is an issue with the review bot applying my review:
https://reviews.apache.org/r/66621/. I think it is due to the accent in my
first name.
So, I created this review to
13 matches
Mail list logo