Re: On launching command tasks

2016-04-11 Thread Alex Rukletsov
Connor, this is also fine and improves current behaviour. On Sat, Apr 9, 2016 at 10:52 PM, wrote: > Hi Alex, inline. > > > On Apr 9, 2016, at 12:00, Alex Rukletsov wrote: > > > > if `shell` is false and `argv.size` is > > 0, assign command to

Re: On launching command tasks

2016-04-09 Thread connor . p . d
Hi Alex, inline. > On Apr 9, 2016, at 12:00, Alex Rukletsov wrote: > > if `shell` is false and `argv.size` is > 0, assign command to `argv[0]`? Instead of trying to fix the TaskInfo on behalf of the framework, maybe it would be more transparent to preemptively fail the

Re: On launching command tasks

2016-04-09 Thread Alex Rukletsov
Under "expect" I meant that Mesos expects users to set CommandInfo.arguments in a way `exec` does not error out. I'm an ESL, but I would have used "require" if we had validation in place. We don't, and I find this unfortunate. I see why one may want to set argv[0] to a value different from the

Re: On launching command tasks

2016-04-08 Thread Benjamin Mahler
> > Mesos expects the first argument to be the same > as the command itself [1] To be precise, what does "expect" mean here? Do we actually have code in mesos with this expectation? Or are you just saying that we require CommandInfo.arguments to map directly to exec's 'args'? Have you

Re: On launching command tasks

2016-04-02 Thread Guangya Liu
+1 on using docker mode, this can help the framework developer. Setting the command twice can sometimes make people confused. When I was working for the patch https://reviews.apache.org/r/1/ , I was also a bit confused before go through the code in agent part. On Sat, Apr 2, 2016 at 1:17

On launching command tasks

2016-04-01 Thread Alex Rukletsov
When launching a command task without wrapping it in `/bin/sh -c` (i.e. CommandInfo.shell=false), Mesos expects the first argument to be the same as the command itself [1]. Though this is similar to how UNIX exec* calls operate, it can be unclear to a user. Moreover, we do not validate this on the