Re: Container launch metrics on agent

2017-12-12 Thread Jie Yu
+ Joseph Gilbert Yeah, we need to follow up with some cleanups. This also applies to nested container. - Jie On Tue, Dec 12, 2017 at 10:09 AM, Zhitao Li wrote: > > > On Mon, Dec 11, 2017 at 7:34 PM, Benjamin Mahler > wrote: > >> 1) My guess is that we only added the errors because we alerted

Re: Container launch metrics on agent

2017-12-12 Thread Zhitao Li
On Mon, Dec 11, 2017 at 7:34 PM, Benjamin Mahler wrote: > 1) My guess is that we only added the errors because we alerted on there > being an error increase. I assume you also care about every error? Having a > 'success' count and 'total' count sounds reasonable to me. > Thanks I filed https://i

Re: Container launch metrics on agent

2017-12-11 Thread Benjamin Mahler
1) My guess is that we only added the errors because we alerted on there being an error increase. I assume you also care about every error? Having a 'success' count and 'total' count sounds reasonable to me. 2) Not sure, have you read the code? What would you want to be the case? Would you need th