Re: mesos git commit: Added mpsc_linked_queue and use it as the concurrent event queue.

2018-07-16 Thread Dario Rexin
Btw. I use 128 bytes here because of PowerPC. We don’t depend on it to perform well on PPC, but since there has been some work around PPC support I thought I’d make it work for it as well. If you think we should default to x86 cache line size, I’ll change that as well. > On Jul 16, 2018, at 8:

Re: mesos git commit: Added mpsc_linked_queue and use it as the concurrent event queue.

2018-07-16 Thread Dario Rexin
Hi Benjamin, see comments inline. > On Jul 16, 2018, at 5:48 AM, Benjamin Bannier > wrote: > > Hi Dario, > > this patch introduced two new clang-tidy warnings. Could we try to get these > down to zero, even if the code does not look bad? > > > I already created a patch for the unused lambd

Re: mesos git commit: Added mpsc_linked_queue and use it as the concurrent event queue.

2018-07-16 Thread Benjamin Bannier
Hi Dario, this patch introduced two new clang-tidy warnings. Could we try to get these down to zero, even if the code does not look bad? I already created a patch for the unused lambda capture, https://reviews.apache.org/r/67927/ While the code does look reasonable, as a somewhat weird ex