Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

> On May 20, 2014, 12:34 a.m., Tobias Weingartner wrote: > > src/slave/containerizer/mesos_containerizer.cpp, line 442 > > > > > > Should contain a mode (0666). Aye, that is what is biting us now in MESOS-1402 - Til

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review43452 --- Ship it! The rest lgtm. - Tobias Weingartner On May 19, 2014, 10

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review43447 --- src/slave/containerizer/mesos_containerizer.cpp

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/ --- (Updated May 19, 2014, 3:57 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/ --- (Updated May 16, 2014, 3:06 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review43291 --- Ship it! LGTM. Ditto BenM's comment. Do we have any existing test t

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

> On May 16, 2014, 6:11 p.m., Tobias Weingartner wrote: > > src/slave/containerizer/mesos_containerizer.cpp, lines 323-325 > > > > > > While this may work, there is no POSIX reason that you could not get a > > short r

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

> On May 16, 2014, 11:11 a.m., Tobias Weingartner wrote: > > In general, I'd love to see us actually print out either the errno value, > > or even better the errno string upon an ABORT() or other failure caused by > > a syscall. It makes tracking down issues much easier. Yes, that would be pr

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

> On May 6, 2014, 10:56 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos_containerizer.cpp, lines 544-551 > > > > > > This is now part of 'fetch', but it has nothing to do with 'fetch'. How > > about pulling it t

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review43245 --- I held off from making too many comments since I see you've been res

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review43231 --- In general, I'd love to see us actually print out either the errno v

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review42390 --- Bad patch! Reviews applied: [20816] Failed command: git apply --in

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review42301 --- src/slave/containerizer/mesos_containerizer.cpp

Review Request 20958: Make execute in MesosContainerizer async signal safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/ --- Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Repository: mesos