Re: Review Request 25250: Mark running tasks killed during framework shutdown.

> On Oct. 22, 2014, 9:19 a.m., Adam B wrote: > > I took care of these for Alex since he was blocked on my JSON::Object.find updates. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review57771 --- src/master/master.cpp

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review56155 --- Patch looks great! Reviews applied: [25250] All tests passed. - M

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Oct. 10, 2014, 2:15 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

> On Oct. 9, 2014, 8:01 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, line 168 > > > > > > Any reason for these changes? Do you have any reference on if '>>' > > disambiguation is supported by our graced

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

> On Oct. 9, 2014, 7:55 p.m., Timothy Chen wrote: > > src/tests/master_tests.cpp, line 265 > > > > > > Perhaps you should do EXPECT so you can cleanly shutdown in the end. If the response has not been parsed successfu

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review56042 --- src/tests/master_tests.cpp

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review56041 --- src/tests/master_tests.cpp

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Oct. 9, 2014, 5:05 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Oct. 9, 2014, 4:28 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

> On Sept. 15, 2014, 4:38 p.m., Benjamin Hindman wrote: > > src/master/master.cpp, line 4010 > > > > > > I suggest we use TASK_LOST here instead. We definitely want a terminal > > state like TASK_KILLED, but we've re

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Sept. 22, 2014, 4:25 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

> On Sept. 15, 2014, 4:38 p.m., Benjamin Hindman wrote: > > src/master/master.cpp, line 4010 > > > > > > I suggest we use TASK_LOST here instead. We definitely want a terminal > > state like TASK_KILLED, but we've re

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review53350 --- src/master/master.cpp

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review52560 --- Patch looks great! Reviews applied: [25250] All tests passed. - M

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Sept. 7, 2014, 6:35 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Sept. 4, 2014, 8:45 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review52351 --- Patch looks great! Reviews applied: [25250] All tests passed. - M

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Sept. 3, 2014, 9:56 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Sept. 3, 2014, 9:59 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Sept. 2, 2014, 5:44 p.m.) Review request for mesos, Benjamin Hindman a