Re: Review Request 25261: Check for variadic template and default/deleted function support

2014-09-11 Thread Cody Maloney
> On Sept. 2, 2014, 7:50 p.m., Michael Park wrote: > > Just something to note here, there's a bug in earlier GCC versions where > > the access control of `= default`ed functions aren't enforced correctly. > > > > e.g. > > > > ``` > > class Foo > > { > > private: > > > > Foo() = default; >

Re: Review Request 25261: Check for variadic template and default/deleted function support

2014-09-10 Thread Vinod Kone
> On Sept. 2, 2014, 7:50 p.m., Michael Park wrote: > > Just something to note here, there's a bug in earlier GCC versions where > > the access control of `= default`ed functions aren't enforced correctly. > > > > e.g. > > > > ``` > > class Foo > > { > > private: > > > > Foo() = default; >

Re: Review Request 25261: Check for variadic template and default/deleted function support

2014-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/#review52106 --- Patch looks great! Reviews applied: [25261] All tests passed. - M

Re: Review Request 25261: Check for variadic template and default/deleted function support

2014-09-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/#review52067 --- Just something to note here, there's a bug in earlier GCC versions w

Review Request 25261: Check for variadic template and default/deleted function support

2014-09-02 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-1752 and MESOS-1753