Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-09 Thread Ben Mahler
On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote: src/tests/cluster.hpp, line 597 https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line597 Since you are cleaning up this code, I don't think this variable is necessary anymore? Actually I don't know why it was used in

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/#review52775 --- Ship it! Ship It! - Vinod Kone On Sept. 9, 2014, 12:43 a.m.,

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-09 Thread Vinod Kone
On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote: src/tests/cluster.hpp, line 597 https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line597 Since you are cleaning up this code, I don't think this variable is necessary anymore? Actually I don't know why it was used in

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/#review52612 --- src/tests/mesos.hpp

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-08 Thread Ben Mahler
On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote: src/tests/cluster.hpp, lines 155-164 https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line155 Similar to Slave do you think these should be Owned? Good call, cleaned these up as well. - Ben

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/ --- (Updated Sept. 9, 2014, 12:42 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/ --- (Updated Sept. 9, 2014, 12:43 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-08 Thread Vinod Kone
On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote: src/tests/cluster.hpp, line 597 https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line597 Since you are cleaning up this code, I don't think this variable is necessary anymore? Actually I don't know why it was used in

Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1715