Re: Review Request 25508: Fix git clean -xdf skipping leveldb

2014-09-10 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25508/#review52919 --- Ship it! So for completeness the actual diff is not posted here b/c

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

2014-09-10 Thread Timothy St. Clair
> On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote: > > 3rdparty/Makefile.am, line 84 > > > > > > didn't realize that the leveldb we bundle has git files in it! isn't > > the proper fix here to bundle a proper 'dist'ribu

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

2014-09-10 Thread Vinod Kone
> On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote: > > 3rdparty/Makefile.am, line 84 > > > > > > didn't realize that the leveldb we bundle has git files in it! isn't > > the proper fix here to bundle a proper 'dist'ribu

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

2014-09-10 Thread Timothy St. Clair
> On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote: > > 3rdparty/Makefile.am, line 84 > > > > > > didn't realize that the leveldb we bundle has git files in it! isn't > > the proper fix here to bundle a proper 'dist'ribu

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

2014-09-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25508/#review52894 --- 3rdparty/Makefile.am

Review Request 25508: Fix git clean -xdf skipping leveldb

2014-09-10 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25508/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1764 https://i