---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review54300
---
This is coming together really nicely Tim! Just some minor cleanups
On Sept. 23, 2014, 7:10 p.m., Ben Mahler wrote:
src/tests/environment.cpp, lines 57-59
https://reviews.apache.org/r/25569/diff/7/?file=701944#file701944line57
Missing includes for these?
#include set
#include vector
I think it's already included, but I'll add it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 23, 2014, 9:24 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 23, 2014, 10:02 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review54351
---
Ship it!
Thanks so much Tim, this is a great cleanup!
I'll fix
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 22, 2014, 9:17 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review54201
---
Did you look at the diff when you posted this review? Looks like
On Sept. 22, 2014, 10:52 p.m., Ben Mahler wrote:
Did you look at the diff when you posted this review? Looks like you needed
to rebase against master.
Sorry didn't really look at it and you're right it's not rebased!
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 23, 2014, 5:28 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 20, 2014, 5:09 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review53993
---
src/tests/environment.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 19, 2014, 10:27 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review54045
---
Thanks Tim, this is looking really nice!
Appreciate the patience,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review54063
---
Patch looks great!
Reviews applied: [25569]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review53893
---
Thanks Tim, this is a great step forward! Getting close!
Some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 16, 2014, 7:07 a.m.)
Review request for mesos and Ben Mahler.
On Sept. 12, 2014, 11:39 p.m., Ben Mahler wrote:
Thanks for following up!
Not your fault, but the current design of enable() seems a bit unfortunate,
because we will print things excessively unless we use static variables as
you've done here.
What about the following instead?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review53491
---
Bad patch!
Reviews applied: [25569]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review53541
---
src/tests/environment.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 16, 2014, 10:35 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review53627
---
Patch looks great!
Reviews applied: [25569]
All tests passed.
-
21 matches
Mail list logo
