Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/#review53837 --- This more looks like a hack. What if people compile mesos on a

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-18 Thread Timothy St. Clair
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote: src/linux/cgroups.cpp, lines 1778-1792 https://reviews.apache.org/r/25695/diff/2/?file=690745#file690745line1778 So you never cleanup other cgroups (like memory) on machines with systemd? Correct, *never* unmount, this is handled by

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-18 Thread Timothy St. Clair
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote: src/linux/cgroups.cpp, lines 1778-1792 https://reviews.apache.org/r/25695/diff/2/?file=690745#file690745line1778 So you never cleanup other cgroups (like memory) on machines with systemd? Timothy St. Clair wrote: Correct,

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-18 Thread Jie Yu
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote: configure.ac, lines 470-472 https://reviews.apache.org/r/25695/diff/2/?file=690744#file690744line470 Is there a way to eliminate `PKG_CHECK_MODULES`? I think last time, some people have issues when bootstrapping if `PKG_CHECK_MODULES`

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-18 Thread Timothy St. Clair
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote: configure.ac, lines 470-472 https://reviews.apache.org/r/25695/diff/2/?file=690744#file690744line470 Is there a way to eliminate `PKG_CHECK_MODULES`? I think last time, some people have issues when bootstrapping if `PKG_CHECK_MODULES`

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-18 Thread Timothy St. Clair
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote: This more looks like a hack. What if people compile mesos on a machine without systemd and run it on a machine with systemd? I am in favor of a dynamic solution. Have you considered the suggestion I gave last time? I didn't want to interfear

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-18 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/ --- (Updated Sept. 18, 2014, 7:40 p.m.) Review request for mesos, Benjamin

Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1195

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/#review53534 --- Bad patch! Reviews applied: [25695] Failed command: ./configure

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Timothy St. Clair
On Sept. 16, 2014, 3:38 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [25695] Failed command: ./configure Error: checking build system type... x86_64-unknown-linux-gnu checking host system type... x86_64-unknown-linux-gnu checking target system type...

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/ --- (Updated Sept. 16, 2014, 6:19 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/#review53571 --- Patch looks great! Reviews applied: [25695] All tests passed. -

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Vinod Kone
On Sept. 16, 2014, 7:27 p.m., Mesos ReviewBot wrote: Patch looks great! Reviews applied: [25695] All tests passed. I'll let @jieyu comment shepherd this, but I think we should not rush this into 0.20.1 because this is not a bug in 0.20.0. - Vinod