Re: Review Request 25789: Variadic strings join for c++11 and above

> On Sept. 19, 2014, 10:25 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 205 > > > > > > At first I was expecting strings::join to just be variadic on > > std::st

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ --- (Updated Sept. 19, 2014, 6:37 p.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review53949 --- Mostly just style stuff, after a quick cleanup we'll get this commit

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ --- (Updated Sept. 19, 2014, 12:36 a.m.) Review request for mesos and Benjamin Hind

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review53898 --- 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ --- (Updated Sept. 18, 2014, 11:10 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review53891 --- It seems we have mixed use of const char * and std::string in the us

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ --- (Updated Sept. 18, 2014, 10:22 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 25789: Variadic strings join for c++11 and above

> On Sept. 18, 2014, 8:11 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 190 > > > > > > given that we test for variadic template support in configure, do you > > thi

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review53862 --- 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp

Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Descript