Re: Review Request 26147: Remove non-variadic strings::format() implementation

2015-03-26 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review77910 --- Ship it! Ship It! - Benjamin Hindman On March 25, 2015, 8:02 p.m

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2015-03-25 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/ --- (Updated March 25, 2015, 8:02 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2015-03-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review77506 --- Hey Cody, can you adda JIRA for this patch? - Niklas Nielsen On M

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2015-03-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review76820 --- Patch looks great! Reviews applied: [26147] All tests passed. - M

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2015-03-17 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/ --- (Updated March 17, 2015, 8:02 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2014-09-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review54920 --- Patch looks great! Reviews applied: [26147] All tests passed. - M

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2014-09-29 Thread Dominic Hamon
> On Sept. 29, 2014, 2:13 p.m., Dominic Hamon wrote: > > we check in configure in mesos, not in stout. we'd have to bubble those > > c++11 checks down the stack through libprocess and into stout before we can > > responsibly deprecate this (and other) c++11 guards. > > Cody Maloney wrote: >

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2014-09-29 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/ --- (Updated Sept. 29, 2014, 9:40 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2014-09-29 Thread Cody Maloney
> On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote: > > we check in configure in mesos, not in stout. we'd have to bubble those > > c++11 checks down the stack through libprocess and into stout before we can > > responsibly deprecate this (and other) c++11 guards. > > Cody Maloney wrote: >

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2014-09-29 Thread Dominic Hamon
On Mon, Sep 29, 2014 at 2:24 PM, Cody Maloney wrote: > > > > On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote: > > > we check in configure in mesos, not in stout. we'd have to bubble > those c++11 checks down the stack through libprocess and into stout before > we can responsibly deprecate this

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2014-09-29 Thread Cody Maloney
> On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote: > > we check in configure in mesos, not in stout. we'd have to bubble those > > c++11 checks down the stack through libprocess and into stout before we can > > responsibly deprecate this (and other) c++11 guards. We already use them in stout

Re: Review Request 26147: Remove non-variadic strings::format() implementation

2014-09-29 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review54876 --- we check in configure in mesos, not in stout. we'd have to bubble th

Review Request 26147: Remove non-variadic strings::format() implementation

2014-09-29 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/ --- Review request for mesos and Dominic Hamon. Repository: mesos-git Description