Re: Review Request 27111: Block IO Isolator: usage metrics

2014-10-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/ --- (Updated Oct. 25, 2014, 5:48 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27111: Block IO Isolator: usage metrics

2014-10-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/ --- (Updated Oct. 25, 2014, 5:53 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27111: Block IO Isolator: usage metrics

2014-10-25 Thread Joris Van Remoortere
On Oct. 25, 2014, 1:02 a.m., Ian Downes wrote: src/slave/containerizer/isolators/cgroups/blkio.cpp, line 252 https://reviews.apache.org/r/27111/diff/2/?file=731349#file731349line252 What's the difference between blkio.throttle.io_service_bytes and blkio.io_service_bytes? From

Re: Review Request 27111: Block IO Isolator: usage metrics

2014-10-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/#review58524 --- Patch looks great! Reviews applied: [27111] All tests passed. -

Re: Review Request 27111: Block IO Isolator: usage metrics

2014-10-24 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/#review58418 --- Close to ready. Major points are cleaning up the cgroups statistics

Review Request 27111: Block IO Isolator: usage metrics

2014-10-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/ --- Review request for mesos, Benjamin Hindman and Ian Downes. Bugs: MESOS-1977

Re: Review Request 27111: Block IO Isolator: usage metrics

2014-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/#review58109 --- Bad patch! Reviews applied: [27111] Failed command:

Re: Review Request 27111: Block IO Isolator: usage metrics

2014-10-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/ --- (Updated Oct. 23, 2014, 9:58 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27111: Block IO Isolator: usage metrics

2014-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/#review58221 --- Patch looks great! Reviews applied: [27111] All tests passed. -