Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-11-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/#review61575 --- Can I get you to rebase this one as well? - Niklas Nielsen On

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-11-14 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- (Updated Nov. 15, 2014, 2:16 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-11-12 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- (Updated Nov. 12, 2014, 7 p.m.) Review request for mesos, Benjamin Hindman and

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-11-12 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- (Updated Nov. 12, 2014, 7:18 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-11-12 Thread Dominic Hamon
On Nov. 10, 2014, 11:29 a.m., Niklas Nielsen wrote: 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4, line 84 https://reviews.apache.org/r/27351/diff/2/?file=742017#file742017line84 This tests that is compiles but not whether it works as expected wrt ownership. Maybe that's ok?

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-11-12 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/#review61061 --- Ship it! It would be great to document in the Mesos style guide

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-11-10 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/#review60646 --- Ship it! LGTM - have one question (inlined)

Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-10-29 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2010

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-10-29 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/#review59053 --- 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-10-29 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- (Updated Oct. 29, 2014, 10:23 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

2014-10-29 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/#review59057 --- Ship it! I don't know that it's necessary given the architecture