On Dec. 15, 2014, 1:47 p.m., Dominic Hamon wrote:
include/mesos/resources.hpp, line 213
https://reviews.apache.org/r/29018/diff/1/?file=791218#file791218line213
not quite. emplace_back with a unique_ptr works because unique_ptr
doesn't have a copy constructor. however, as it
On Dec. 15, 2014, 9:29 p.m., Ben Mahler wrote:
include/mesos/resources.hpp, lines 191-202
https://reviews.apache.org/r/29018/diff/1/?file=791218#file791218line191
Great, do we want to specify what a valid transformation is? In
particular, it seems like the invariant of a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29018/
---
(Updated Dec. 16, 2014, 9:10 p.m.)
Review request for mesos and Ben Mahler.
On Dec. 15, 2014, 9:29 p.m., Ben Mahler wrote:
include/mesos/resources.hpp, lines 211-214
https://reviews.apache.org/r/29018/diff/1/?file=791218#file791218line211
To keep consistent with the rest of the code base, couldn't you have
done the following?
```
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29018/#review65241
---
Ship it!
include/mesos/resources.hpp
On Dec. 16, 2014, 9:42 p.m., Ben Mahler wrote:
include/mesos/resources.hpp, lines 190-198
https://reviews.apache.org/r/29018/diff/2/?file=793220#file793220line190
Maybe this could be a bit more succinct:
```
// This is an abstraction for describing a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29018/#review65096
---
include/mesos/resources.hpp
On Dec. 15, 2014, 6:08 p.m., Dominic Hamon wrote:
include/mesos/resources.hpp, line 213
https://reviews.apache.org/r/29018/diff/1/?file=791218#file791218line213
transformations.emplace_back (if we have it in 4.4) might save you the
explicit move call, and will certainly save you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29018/#review65121
---
Thanks Jie!
include/mesos/resources.hpp
On Dec. 15, 2014, 1:29 p.m., Ben Mahler wrote:
include/mesos/resources.hpp, lines 211-214
https://reviews.apache.org/r/29018/diff/1/?file=791218#file791218line211
To keep consistent with the rest of the code base, couldn't you have
done the following?
```
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29018/#review65125
---
include/mesos/resources.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29018/#review65156
---
include/mesos/resources.hpp
On Dec. 15, 2014, 9:47 p.m., Dominic Hamon wrote:
include/mesos/resources.hpp, line 213
https://reviews.apache.org/r/29018/diff/1/?file=791218#file791218line213
not quite. emplace_back with a unique_ptr works because unique_ptr
doesn't have a copy constructor. however, as it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29018/#review65180
---
I depended on this review in r/29083/, but I assumed that the disk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29018/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-2030
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29018/
---
(Updated Dec. 13, 2014, 5:57 a.m.)
Review request for mesos and Ben Mahler.
16 matches
Mail list logo
