On Feb. 18, 2015, 11:38 a.m., Niklas Nielsen wrote:
Let's get tests wired up before committing this :)
Adam B wrote:
Sure thing. Adding tests in my subsequent patch where we will pass the
master's timeout values on to the slave. Will post that very soon.
Ben Mahler wrote:
On Feb. 18, 2015, 7:38 p.m., Niklas Nielsen wrote:
Let's get tests wired up before committing this :)
Adam B wrote:
Sure thing. Adding tests in my subsequent patch where we will pass the
master's timeout values on to the slave. Will post that very soon.
Ben Mahler wrote:
Can
On Feb. 18, 2015, 11:38 a.m., Niklas Nielsen wrote:
Let's get tests wired up before committing this :)
Adam B wrote:
Sure thing. Adding tests in my subsequent patch where we will pass the
master's timeout values on to the slave. Will post that very soon.
Ben Mahler wrote:
On March 6, 2015, 5:19 a.m., Joerg Schad wrote:
src/master/flags.hpp, line 383
https://reviews.apache.org/r/29507/diff/4/?file=868836#file868836line383
Shouldn't this also be added to the documentation (i.e.
http://mesos.apache.org/documentation/latest/configuration/)?
Excellent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review75484
---
src/master/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated Feb. 19, 2015, 12:10 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review73111
---
Patch looks great!
Reviews applied: [29507]
All tests passed.
-
On Feb. 18, 2015, 11:38 a.m., Niklas Nielsen wrote:
Let's get tests wired up before committing this :)
Adam B wrote:
Sure thing. Adding tests in my subsequent patch where we will pass the
master's timeout values on to the slave. Will post that very soon.
Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review72992
---
Let's get tests wired up before committing this :)
- Niklas
On Feb. 18, 2015, 11:38 a.m., Niklas Nielsen wrote:
Let's get tests wired up before committing this :)
Sure thing. Adding tests in my subsequent patch where we will pass the master's
timeout values on to the slave. Will post that very soon.
- Adam
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review73085
---
Bad patch!
Reviews applied: [29507]
Failed command:
On Feb. 18, 2015, 7:38 p.m., Niklas Nielsen wrote:
Let's get tests wired up before committing this :)
Adam B wrote:
Sure thing. Adding tests in my subsequent patch where we will pass the
master's timeout values on to the slave. Will post that very soon.
Can you do it in one patch?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated Feb. 18, 2015, 4:33 p.m.)
Review request for mesos and Niklas
On Jan. 7, 2015, 2:50 p.m., Ben Mahler wrote:
src/master/flags.hpp, lines 361-373
https://reviews.apache.org/r/29507/diff/1/?file=804645#file804645line361
Do you mind changing the names now that they're merely defaults?
s/SLAVE_PING_TIMEOUT/DEFAULT_SLAVE_PING_TIMEOUT/
On Jan. 7, 2015, 2:50 p.m., Ben Mahler wrote:
src/master/flags.hpp, lines 361-373
https://reviews.apache.org/r/29507/diff/1/?file=804645#file804645line361
Do you mind changing the names now that they're merely defaults?
s/SLAVE_PING_TIMEOUT/DEFAULT_SLAVE_PING_TIMEOUT/
On Jan. 7, 2015, 10:50 p.m., Ben Mahler wrote:
src/master/flags.hpp, lines 361-373
https://reviews.apache.org/r/29507/diff/1/?file=804645#file804645line361
Do you mind changing the names now that they're merely defaults?
s/SLAVE_PING_TIMEOUT/DEFAULT_SLAVE_PING_TIMEOUT/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review67183
---
Patch looks great!
Reviews applied: [29507]
All tests passed.
-
On Jan. 7, 2015, 2:50 p.m., Ben Mahler wrote:
src/master/flags.hpp, lines 361-373
https://reviews.apache.org/r/29507/diff/1/?file=804645#file804645line361
Do you mind changing the names now that they're merely defaults?
s/SLAVE_PING_TIMEOUT/DEFAULT_SLAVE_PING_TIMEOUT/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated Jan. 8, 2015, 12:44 a.m.)
Review request for mesos and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review67182
---
src/tests/partition_tests.cpp
On Jan. 6, 2015, 9:17 a.m., Niklas Nielsen wrote:
src/tests/mesos.cpp, line 129
https://reviews.apache.org/r/29507/diff/1/?file=804648#file804648line129
Can we use a constant here instead (to make sure it follows future
changes to the default value?)
The point of setting these
On Jan. 6, 2015, 9:17 a.m., Niklas Nielsen wrote:
src/tests/mesos.cpp, line 129
https://reviews.apache.org/r/29507/diff/1/?file=804648#file804648line129
Can we use a constant here instead (to make sure it follows future
changes to the default value?)
Adam B wrote:
The
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review67113
---
src/master/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review67077
---
src/master/master.cpp
On Jan. 7, 2015, 8:22 p.m., Michael Park wrote:
Looks good to me. Just a minor comment on consistent variable naming.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
On Jan. 6, 2015, 5:17 p.m., Niklas Nielsen wrote:
src/tests/mesos.cpp, line 129
https://reviews.apache.org/r/29507/diff/1/?file=804648#file804648line129
Can we use a constant here instead (to make sure it follows future
changes to the default value?)
Adam B wrote:
The
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review66859
---
Looks good! Have a couple of small questions
src/master/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-2150
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review66461
---
Patch looks great!
Reviews applied: [29507]
All tests passed.
-
29 matches
Mail list logo
