Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-02-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Feb. 11, 2015, 7:57 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/#review71044 --- Just curious, what did you need this stuff for? Inferring

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-02-04 Thread Michael Park
On Feb. 4, 2015, 9:38 p.m., Ben Mahler wrote: Just curious, what did you need this stuff for? Inferring operations, or? It came in handy when writing the `validate` functions for `RESERVE` and `UNRESERVE` in https://reviews.apache.org/r/30361/. They also work great as the predicates to the

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-02-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Feb. 5, 2015, 12:55 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-02-04 Thread Michael Park
On Feb. 3, 2015, 8:19 p.m., Vinod Kone wrote: include/mesos/resources.hpp, line 92 https://reviews.apache.org/r/29742/diff/4/?file=839661#file839661line92 We didn't do isempty above, so how about getting rid of is as prefix? I think returning a bool signals a is. Michael Park

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-02-03 Thread Michael Park
On Feb. 3, 2015, 8:19 p.m., Vinod Kone wrote: include/mesos/resources.hpp, line 92 https://reviews.apache.org/r/29742/diff/4/?file=839661#file839661line92 We didn't do isempty above, so how about getting rid of is as prefix? I think returning a bool signals a is. Hm, that's a

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/#review70817 --- Ship it! include/mesos/resources.hpp

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 28, 2015, 9:21 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 28, 2015, 9:21 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 29, 2015, 5:24 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 29, 2015, 5:27 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 23, 2015, 7:18 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 14, 2015, 6:55 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 13, 2015, 7:03 p.m.) Review request for mesos, Adam B, Benjamin

Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- Review request for mesos. Repository: mesos-git Description --- A

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 9, 2015, 1:33 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 9, 2015, 1:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 9, 2015, 1:53 a.m.) Review request for mesos, Adam B, Benjamin