Re: Review Request 29742: Added utility functions to determine types of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Feb. 17, 2015, 8:08 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added utility functions to determine types of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/#review72659 --- Ship it! Thanks for the cleanup! src/master/validation.cpp

Re: Review Request 29742: Added utility functions to determine types of resources.

On Feb. 13, 2015, 12:35 p.m., Alexander Rukletsov wrote: src/master/validation.cpp, line 65 https://reviews.apache.org/r/29742/diff/6/?file=860711#file860711line65 Does it makes sense to use `Resources::persistentVolume()` predicate here? IIUC we do want check exactly this, but

Re: Review Request 29742: Added utility functions to determine types of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/#review72550 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 13, 2015, 10:59

Re: Review Request 29742: Added utility functions to determine types of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Feb. 13, 2015, 10:59 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added utility functions to determine types of resources.

On Feb. 13, 2015, 12:35 p.m., Alexander Rukletsov wrote: src/master/validation.cpp, line 65 https://reviews.apache.org/r/29742/diff/6/?file=860711#file860711line65 Does it makes sense to use `Resources::persistentVolume()` predicate here? IIUC we do want check exactly this, but

Re: Review Request 29742: Added utility functions to determine types of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Feb. 13, 2015, 10:58 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added utility functions to determine types of resources.

On Feb. 13, 2015, 12:35 p.m., Alexander Rukletsov wrote: src/master/validation.cpp, line 105 https://reviews.apache.org/r/29742/diff/6/?file=860711#file860711line105 `!Resources::persistentVolume(resource)`, if my mental boolean algebra works. Could you please grep the code base

Re: Review Request 29742: Added utility functions to determine types of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/#review72358 --- Nice motivation for the change, Michael! Let's create a JIRA for

Re: Review Request 29742: Added utility functions to determine types of resources.

On Feb. 3, 2015, 8:19 p.m., Vinod Kone wrote: include/mesos/resources.hpp, line 92 https://reviews.apache.org/r/29742/diff/4/?file=839661#file839661line92 We didn't do isempty above, so how about getting rid of is as prefix? I think returning a bool signals a is. Michael Park

Re: Review Request 29742: Added utility functions to determine types of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Feb. 11, 2015, 11:23 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added utility functions to determine types of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Feb. 11, 2015, 11:49 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29742: Added utility functions to determine types of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Feb. 11, 2015, 7:57 a.m.) Review request for mesos, Adam B, Benjamin