Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71796 --- Ship it! Ship It! - Vinod Kone On Feb. 10, 2015, 11:33 a.m.,

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71794 --- Patch looks great! Reviews applied: [29883] All tests passed. -

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/ --- (Updated Feb. 10, 2015, 12:33 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71639 --- Ship it! src/master/http.cpp

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/ --- (Updated Feb. 9, 2015, 5:49 p.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71647 --- Patch looks great! Reviews applied: [29883] All tests passed. -

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-05 Thread Alexander Rojas
On Feb. 5, 2015, 2:40 p.m., Alexander Rukletsov wrote: src/master/master.cpp, lines 613-615 https://reviews.apache.org/r/29883/diff/5/?file=847364#file847364line613 Shouldn't it be /slaves.json? If yes, please correct in other places as well. So this was discussed this with

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71205 --- Clean and brief, I like it! Some thoughts below.

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-05 Thread Alexander Rukletsov
On Feb. 5, 2015, 1:40 p.m., Alexander Rukletsov wrote: src/master/master.cpp, lines 613-615 https://reviews.apache.org/r/29883/diff/5/?file=847364#file847364line613 Shouldn't it be /slaves.json? If yes, please correct in other places as well. Alexander Rojas wrote: So

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-05 Thread Alexander Rojas
On Feb. 5, 2015, 2:40 p.m., Alexander Rukletsov wrote: src/master/http.cpp, line 382 https://reviews.apache.org/r/29883/diff/5/?file=847362#file847362line382 Can there be any security issues with exposing slave's PID? Any reason we want to expose it? Alexander Rojas wrote:

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/ --- (Updated Feb. 4, 2015, 11:37 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 29883: Added /master/slaves endpoint.

2015-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review70950 --- Patch looks great! Reviews applied: [29883] All tests passed. -