Re: Review Request 30508: Prepare persistent volumes in slave.

2015-02-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/#review71822 --- Ship it! src/tests/persistent_volume_tests.cpp

Re: Review Request 30508: Prepare persistent volumes in slave.

2015-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/ --- (Updated Feb. 9, 2015, 6 p.m.) Review request for mesos, Ben Mahler, Michael

Re: Review Request 30508: Prepare persistent volumes in slave.

2015-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/#review71650 --- Bad patch! Reviews applied: [30283, 30298, 28781, 30386, 30349]

Re: Review Request 30508: Prepare persistent volumes in slave.

2015-02-09 Thread Jie Yu
On Feb. 9, 2015, 8:12 p.m., Vinod Kone wrote: src/slave/slave.cpp, line 3765 https://reviews.apache.org/r/30508/diff/2/?file=858752#file858752line3765 also, add a check for persistence? This is not needed because the if guard above should have already verified it. - Jie

Re: Review Request 30508: Prepare persistent volumes in slave.

2015-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/ --- (Updated Feb. 9, 2015, 10:37 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 30508: Prepare persistent volumes in slave.

2015-02-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/#review70622 --- Bad patch! Reviews applied: [30283, 30298, 28781, 30283, 30298,

Review Request 30508: Prepare persistent volumes in slave.

2015-02-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Summary

Re: Review Request 30508: Prepare persistent volumes in slave.

2015-02-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/ --- (Updated Feb. 2, 2015, 6:37 p.m.) Review request for mesos, Ben Mahler,