---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30531/
---
(Updated Feb. 4, 2015, 9:40 a.m.)
Review request for mesos and Jie Yu.
Bugs:
On Feb. 3, 2015, 5:32 p.m., Jie Yu wrote:
src/slave/paths.cpp, line 453
https://reviews.apache.org/r/30531/diff/1/?file=844643#file844643line453
const string directory
the function returns a string by value. there's no improvement here using a
const ref (the copy will be elided).
On Feb. 4, 2015, 1:32 a.m., Jie Yu wrote:
src/slave/paths.cpp, line 453
https://reviews.apache.org/r/30531/diff/1/?file=844643#file844643line453
const string directory
Dominic Hamon wrote:
the function returns a string by value. there's no improvement here using
a const
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30531/#review70984
---
Ship it!
src/slave/paths.cpp
On Feb. 4, 2015, 1:32 a.m., Jie Yu wrote:
src/slave/paths.cpp, line 453
https://reviews.apache.org/r/30531/diff/1/?file=844643#file844643line453
const string directory
Dominic Hamon wrote:
the function returns a string by value. there's no improvement here using
a const
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30531/#review70885
---
Can we seperate the tests changes in this patch? It is a good
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30531/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-2314
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30531/#review70659
---
Patch looks great!
Reviews applied: [30531]
All tests passed.
-
