Review Request 30635: Fixed MESOS-2319 by creating the temporary file under the same base directory.

2015-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30635/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Bugs:

Re: Review Request 30635: Fixed MESOS-2319 by creating the temporary file under the same base directory.

2015-02-04 Thread Jie Yu
On Feb. 4, 2015, 8:31 p.m., Ben Mahler wrote: Is there a test of this function? Might be nice to add a NOTE or TODO about how to address the issue of leaving dangling files when we failover at the wrong time? Jie Yu wrote: Yes, SlaveStateTest should catch the regression.

Re: Review Request 30635: Fixed MESOS-2319 by creating the temporary file under the same base directory.

2015-02-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30635/#review71033 --- Ship it! Ship It! - Vinod Kone On Feb. 4, 2015, 7:38 p.m., Jie

Re: Review Request 30635: Fixed MESOS-2319 by creating the temporary file under the same base directory.

2015-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30635/#review71035 --- Ship it! Is there a test of this function? Might be nice to add a

Re: Review Request 30635: Fixed MESOS-2319 by creating the temporary file under the same base directory.

2015-02-04 Thread Jie Yu
On Feb. 4, 2015, 8:31 p.m., Ben Mahler wrote: Is there a test of this function? Might be nice to add a NOTE or TODO about how to address the issue of leaving dangling files when we failover at the wrong time? Yes, SlaveStateTest should catch the regression. Will add a NOTE, the