Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated April 3, 2015, 9:58 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated April 3, 2015, 10:36 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated April 3, 2015, 10:17 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated April 4, 2015, 12:39 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/#review78861 --- src/slave/containerizer/mesos/containerizer.hpp

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated April 1, 2015, 3:44 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-31 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/#review78422 --- src/tests/port_mapping_tests.cpp

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-31 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated April 1, 2015, 12:41 a.m.) Review request for mesos, Chi Zhang, Ian

Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs:

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/#review78341 --- Patch looks great! Reviews applied: [32655] All tests passed. -

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/#review78322 --- Bad patch! Reviews applied: [32655] Failed command:

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated March 31, 2015, 3:52 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated March 31, 2015, 5:35 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated March 31, 2015, 3:55 a.m.) Review request for mesos, Chi Zhang, Ian