Re: Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

2015-04-03 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/ --- (Updated April 3, 2015, 10:36 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

2015-04-03 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/ --- (Updated April 3, 2015, 9:55 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

2015-04-03 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/#review78852 --- src/slave/containerizer/isolators/network/port_mapping.hpp

Re: Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

2015-04-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/ --- (Updated April 1, 2015, 3:44 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

2015-04-01 Thread Paul Brett
On March 31, 2015, 11:38 p.m., Chi Zhang wrote: src/tests/port_mapping_tests.cpp, lines 188-192 https://reviews.apache.org/r/32656/diff/1/?file=910499#file910499line188 having no output here isn't expected; why delay reporting it? Having no output here is currently an expected

Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

2015-03-31 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/ --- Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs:

Re: Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

2015-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/#review78357 --- Patch looks great! Reviews applied: [32656] All tests passed. -

Re: Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

2015-03-31 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/#review78432 --- src/tests/port_mapping_tests.cpp

Re: Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

2015-03-31 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/ --- (Updated April 1, 2015, 12:41 a.m.) Review request for mesos, Chi Zhang, Ian