---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25758/
---
(Updated Sept. 18, 2014, 6:04 a.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25758/#review53808
---
Patch looks great!
Reviews applied: [25758]
All tests passed.
-
-1
The docker test failed when I removed the image, and found a problem from
the docker pull implementation.
I've created a reviewboard for a fix: https://reviews.apache.org/r/25758
Will like to get this fixed before releasing it.
Tim
On Wed, Sep 17, 2014 at 9:10 PM, Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25758/#review53811
---
Ship it!
src/docker/docker.hpp
I've committed Tim's fix, we can cut another release candidate and restart
the vote.
On Wed, Sep 17, 2014 at 11:07 PM, Tim Chen t...@mesosphere.io wrote:
-1
The docker test failed when I removed the image, and found a problem from
the docker pull implementation.
I've created a reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25434/
---
(Updated Sept. 18, 2014, 11:03 a.m.)
Review request for mesos, Benjamin
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2382/changes
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2112/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25434/#review53816
---
Patch looks great!
Reviews applied: [25434]
All tests passed.
-
On Sept. 9, 2014, 4:39 p.m., Niklas Nielsen wrote:
src/exec/exec.cpp, lines 723-729
https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line723
Small nit: We try to keep the variable names short and concise. I would
have dropped the 'mesos' prefix.
Alexander
On Sept. 9, 2014, 4:21 p.m., Timothy Chen wrote:
src/exec/exec.cpp, line 738
https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line738
Why divide by 2 here? It seems like no matter what you're shrinking the
timeout?
Alexander Rukletsov wrote:
I'm not
On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote:
src/launcher/executor.cpp, lines 654-656
https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line654
I'd rather not introduce namespace aliases, can we not put all of this
in mesos::internal?
Alexander Rukletsov
On Sept. 11, 2014, 3:45 p.m., Timothy St. Clair wrote:
src/tests/containerizer.cpp, line 113
https://reviews.apache.org/r/25434/diff/2/?file=683955#file683955line113
Manifest constant please.
Alexander Rukletsov wrote:
Ok.
Use default.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25780/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25755/
---
(Updated Sept. 18, 2014, 11:04 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25780/
---
(Updated Sept. 18, 2014, 11:07 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25780/#review53827
---
Patch looks great!
Reviews applied: [25755, 25780]
All tests
Great. I'll roll that into an rc3 today. Any other patch requests for rc3?
On Thu, Sep 18, 2014 at 2:36 AM, Benjamin Hindman
benjamin.hind...@gmail.com wrote:
I've committed Tim's fix, we can cut another release candidate and restart
the vote.
On Wed, Sep 17, 2014 at 11:07 PM, Tim Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25785/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-1815
Hello
I have just posted a review at https://reviews.apache.org/r/25785/ that
contains a guide to becoming a committer. I'd like comments on this as it
will form a process by which we will grow contributors and I want to make
sure that we all agree on that process.
You can also comment on JIRA
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/#review53837
---
This more looks like a hack. What if people compile mesos on a
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
src/linux/cgroups.cpp, lines 1778-1792
https://reviews.apache.org/r/25695/diff/2/?file=690745#file690745line1778
So you never cleanup other cgroups (like memory) on machines with
systemd?
Correct, *never* unmount, this is handled by
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
src/linux/cgroups.cpp, lines 1778-1792
https://reviews.apache.org/r/25695/diff/2/?file=690745#file690745line1778
So you never cleanup other cgroups (like memory) on machines with
systemd?
Timothy St. Clair wrote:
Correct,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25785/#review53843
---
Where do these dead-lines come from? Has there been any agreement
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
configure.ac, lines 470-472
https://reviews.apache.org/r/25695/diff/2/?file=690744#file690744line470
Is there a way to eliminate `PKG_CHECK_MODULES`? I think last time,
some people have issues when bootstrapping if `PKG_CHECK_MODULES`
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25785/#review53846
---
Patch looks great!
Reviews applied: [25785]
All tests passed.
-
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
configure.ac, lines 470-472
https://reviews.apache.org/r/25695/diff/2/?file=690744#file690744line470
Is there a way to eliminate `PKG_CHECK_MODULES`? I think last time,
some people have issues when bootstrapping if `PKG_CHECK_MODULES`
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25756/
---
(Updated Sept. 18, 2014, 3:02 p.m.)
Review request for mesos.
Repository:
On Sept. 18, 2014, 11:40 a.m., Niklas Nielsen wrote:
Where do these dead-lines come from? Has there been any agreement on this
process in general and doesn't this deserve to be discussed and consensus
reached (dev@ or private) before putting out a document on it?
I might be missing
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
This more looks like a hack. What if people compile mesos on a machine
without systemd and run it on a machine with systemd? I am in favor of a
dynamic solution. Have you considered the suggestion I gave last time?
I didn't want to interfear
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/
---
(Updated Sept. 18, 2014, 7:40 p.m.)
Review request for mesos, Benjamin
On Sept. 12, 2014, 7:03 p.m., Ben Mahler wrote:
Thanks for doing this! A few higher level comments:
(1) We have strings::join in stout. Have you considered implementing this
TLineHelper as a generic Joiner in stout/strings.hpp? Seems like it belongs
there instead of a newline
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review53862
---
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
On Sept. 18, 2014, 8:11 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 190
https://reviews.apache.org/r/25789/diff/1/?file=693848#file693848line190
given that we test for variadic template support in configure, do you
think we still
On Sept. 5, 2014, 9 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp, line 21
https://reviews.apache.org/r/25191/diff/1/?file=672334#file672334line21
can we use __builtin_unreachable instead?
we should probably check for it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25785/#review53869
---
docs/becoming-a-committer.md
Please include the commit log guys, makes cherry picking so much easier!
Sent from my iPhone
On Sep 18, 2014, at 2:08 PM, Timothy Chen (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/MESOS-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
Aye!
Tim
On Thu, Sep 18, 2014 at 2:15 PM, Benjamin Mahler
benjamin.mah...@gmail.com wrote:
Please include the commit log guys, makes cherry picking so much easier!
Sent from my iPhone
On Sep 18, 2014, at 2:08 PM, Timothy Chen (JIRA) j...@apache.org wrote:
[
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25568/
---
(Updated Sept. 18, 2014, 9:30 p.m.)
Review request for mesos, Niklas Nielsen
On Sept. 16, 2014, 6:44 a.m., Vinod Kone wrote:
src/tests/master_tests.cpp, line 2329
https://reviews.apache.org/r/25568/diff/1/?file=687338#file687338line2329
What is the guarantee that offers2 will be made after task's resources
are recovered?
I forgot to pass the resource
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25567/
---
(Updated Sept. 18, 2014, 9:30 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25755/#review53875
---
Ship it!
Ship It!
- Ben Mahler
On Sept. 18, 2014, 3:04 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25780/#review53876
---
Ship it!
Ship It!
- Ben Mahler
On Sept. 18, 2014, 3:07 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25568/#review53878
---
Bad patch!
Reviews applied: [25565]
Failed command: git apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 18, 2014, 10:22 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/
---
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/#review53886
---
+1
- Dominic Hamon
On Sept. 18, 2014, 3:53 p.m., Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review53891
---
It seems we have mixed use of const char * and std::string in the
Hi all,
Please vote on releasing the following candidate as Apache Mesos 0.20.1.
0.20.1 includes the following:
Minor bug fixes for docker integration, network isolation, build, etc.
The CHANGELOG for the release
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 18, 2014, 11:10 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25801/
---
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-184
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/#review53889
---
3rdparty/libprocess/include/process/help.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review53893
---
Thanks Tim, this is a great step forward! Getting close!
Some
On Sept. 18, 2014, 11:14 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/include/process/help.hpp, line 120
https://reviews.apache.org/r/25798/diff/1/?file=693978#file693978line120
std::endl?
std::endl is a flush + '\n'. Note the whole codebase only uses '\n' newlines,
so this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review53898
---
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25801/#review53899
---
Patch looks great!
Reviews applied: [25801]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25805/
---
Review request for mesos, Ben Mahler and Jiang Yan Xu.
Bugs: MESOS-1813
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25805/
---
(Updated Sept. 19, 2014, 12:08 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25801/
---
(Updated Sept. 19, 2014, 12:08 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25801/
---
(Updated Sept. 19, 2014, 12:09 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25568/#review53902
---
Ship it!
src/tests/reconciliation_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25567/#review53904
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 18, 2014, 9:30 p.m.,
On Sept. 18, 2014, 11:14 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/include/process/help.hpp, line 120
https://reviews.apache.org/r/25798/diff/1/?file=693978#file693978line120
std::endl?
Cody Maloney wrote:
std::endl is a flush + '\n'. Note the whole codebase only uses
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/
---
(Updated Sept. 19, 2014, 12:26 a.m.)
Review request for mesos, Benjamin
-- Forwarded message --
From: Stack Exchange do-not-re...@stackexchange.com
Date: Thu, Sep 18, 2014 at 4:33 PM
Subject: New mesos questions for Sep 18 - Stack Exchange
To: vi...@twitter.com
1 new question in Mesos Filter filter
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 19, 2014, 12:36 a.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25801/#review53906
---
Ship it!
- Ben Mahler
On Sept. 19, 2014, 12:09 a.m., Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25805/#review53911
---
Ship it!
src/examples/java/TestFramework.java
+1 (binding)
sudo make check on CentOS 5.5 w/ gcc-4.8.2
On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io wrote:
Hi all,
Please vote on releasing the following candidate as Apache Mesos 0.20.1.
0.20.1 includes the following:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25805/
---
(Updated Sept. 19, 2014, 1:21 a.m.)
Review request for mesos, Ben Mahler and
Probably because they're building Mesos 0.21 and we haven't published
anything to the Maven repo for that yet.
Should either --disable-java or build a stable release like 0.20.
On Thu, Sep 18, 2014 at 5:33 PM, Vinod Kone vinodk...@gmail.com wrote:
-- Forwarded message --
From:
makes sense. mind commenting on SO?
On Thu, Sep 18, 2014 at 6:25 PM, Adam Bordelon a...@mesosphere.io wrote:
Probably because they're building Mesos 0.21 and we haven't published
anything to the Maven repo for that yet.
Should either --disable-java or build a stable release like 0.20.
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25805/#review53917
---
Patch looks great!
Reviews applied: [25801, 25805]
All tests
Commented. I'm now of the opinion that it was a bad apache-11.pom.
On Thu, Sep 18, 2014 at 6:28 PM, Vinod Kone vinodk...@gmail.com wrote:
makes sense. mind commenting on SO?
On Thu, Sep 18, 2014 at 6:25 PM, Adam Bordelon a...@mesosphere.io wrote:
Probably because they're building Mesos
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2385/changes
Changes:
[bmahler] Fixed a signed comparision issue in Version.
[vinodkone] Fixed example frameworks to launch tasks based on offered resources.
[vinodkone] Fixed
On Sept. 11, 2014, 3:45 p.m., Timothy St. Clair wrote:
src/exec/exec.cpp, line 82
https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line82
Maybe I'm missing something, but is there a reason we don't check
before a delay? If ShutdownProcess is spawned, it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25810/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-1818
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25810/#review53923
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 19, 2014, 2:33 a.m.,
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2386/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25819/
---
Review request for mesos.
Repository: mesos-git
Description
---
Force
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25819/
---
(Updated Sept. 19, 2014, 1:20 a.m.)
Review request for mesos and Ben Mahler.
See https://builds.apache.org/job/mesos-reviewbot/1638/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/#review53935
---
Patch looks great!
Reviews applied: [25789, 25798]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/
---
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/
---
(Updated Sept. 19, 2014, 5:32 a.m.)
Review request for mesos and Benjamin
85 matches
Mail list logo
