Re: Mesos Community Meetings

2015-03-05 Thread Vinod Kone
Hi folks, We will try BlueJeans VC (https://bluejeans.com/272369669) this time (today 3 PM PST) for our monthly community sync. Agenda (tentative) Optimistic offers Fetcher cache Release cadence Review process Committership See you in a few hours, Vinod P.S: If

Re: Review Request 31772: Fixed a bug in PosixDiskIsolator during slave recovery.

2015-03-05 Thread Jie Yu
On March 5, 2015, 8:33 p.m., Vinod Kone wrote: src/tests/disk_quota_tests.cpp, line 508 https://reviews.apache.org/r/31772/diff/1/?file=886098#file886098line508 why the if condition? is it possible for disk_used_bytes to not exist? Yes, it's possible if the first 'du' hasn't

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/ --- (Updated March 5, 2015, 9:11 p.m.) Review request for mesos, Kapil Arya,

Review Request 31772: Fixed a bug in PosixDiskIsolator during slave recovery.

2015-03-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31772/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs:

Build failed in Jenkins: mesos-reviewbot #4452

2015-03-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/4452/ -- [URLTrigger] A change within the response URL invocation (log) [URLTrigger] A change within the response URL invocation (log) Building remotely on H10 (Ubuntu ubuntu) in workspace

Re: Review Request 30841: Remove static strings and split process.cpp

2015-03-05 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30841/ --- (Updated March 5, 2015, 11:39 a.m.) Review request for mesos and Jie Yu.

Re: Mesos Community Meetings

2015-03-05 Thread Dave Lester
A few questions: 1) Was this announced on the mailing list? I'm hearing about this for the first time and imagine others may be in the same boat 2) How was the agenda created? it would be awesome if we could track each community meeting somehow to allow folks to suggest agenda items, perhaps this

Re: Review Request 29288: stout: Extend the IP and IPNetwork classes to support IPv6.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/ --- (Updated March 5, 2015, 7:38 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31471/ --- (Updated March 5, 2015, 7:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/ --- (Updated March 5, 2015, 9:06 p.m.) Review request for mesos, Kapil Arya,

Review Request 31776: Moved allocator to public headers.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31776/ --- Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. Bugs:

Re: Review Request 31266: Added support for allocator modules.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31266/ --- (Updated March 5, 2015, 9:05 p.m.) Review request for mesos, Kapil Arya,

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated March 5, 2015, 7:22 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 30952: Adding scheduler validations to master

2015-03-05 Thread Isabel Jimenez
On March 5, 2015, 8:21 p.m., Vinod Kone wrote: i'll take a look once the marked issues are resolved. Done - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30952/#review75383

Re: Review Request 31772: Fixed a bug in PosixDiskIsolator during slave recovery.

2015-03-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31772/#review75385 --- src/slave/containerizer/mesos/containerizer.cpp

Build failed in Jenkins: mesos-reviewbot #4451

2015-03-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/4451/ -- [URLTrigger] A change within the response URL invocation (log) [URLTrigger] A change within the response URL invocation (log) [URLTrigger] A change within the response URL invocation (log) Building

Re: Review Request 31772: Fixed a bug in PosixDiskIsolator during slave recovery.

2015-03-05 Thread Vinod Kone
On March 5, 2015, 8:33 p.m., Vinod Kone wrote: src/tests/disk_quota_tests.cpp, line 508 https://reviews.apache.org/r/31772/diff/1/?file=886098#file886098line508 why the if condition? is it possible for disk_used_bytes to not exist? Jie Yu wrote: Yes, it's possible if the

Review Request 31775: Removed Master::Flags dependency from Allocator.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31775/ --- Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. Bugs:

Re: Review Request 31262: Moved allocator actions before TestAllocator.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31262/ --- (Updated March 5, 2015, 9:05 p.m.) Review request for mesos, Kapil Arya,

Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/ --- (Updated March 5, 2015, 7:38 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30952: Adding scheduler validations to master

2015-03-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30952/#review75383 --- i'll take a look once the marked issues are resolved. - Vinod Kone

Build failed in Jenkins: mesos-reviewbot #4450

2015-03-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/4450/ -- [URLTrigger] A change within the response URL invocation (log) [URLTrigger] A change within the response URL invocation (log) [URLTrigger] A change within the response URL invocation (log)

Re: Review Request 31772: Fixed a bug in PosixDiskIsolator during slave recovery.

2015-03-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31772/ --- (Updated March 5, 2015, 8:55 p.m.) Review request for mesos, Ben Mahler, Ian

Build failed in Jenkins: Mesos-Ubuntu-distcheck #714

2015-03-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/714/ -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM

Re: Review Request 31265: Provided a factory for allocator in tests.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/ --- (Updated March 5, 2015, 9:07 p.m.) Review request for mesos, Kapil Arya,

Re: Review Request 31268: Wired up test allocator to allocator tests.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/ --- (Updated March 5, 2015, 9:07 p.m.) Review request for mesos, Kapil Arya,

Re: Review Request 31776: Moved allocator to public headers.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31776/ --- (Updated March 5, 2015, 9:11 p.m.) Review request for mesos, Kapil Arya,

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2794

2015-03-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2794/ -- Started by an SCM change Building remotely on ubuntu-5 (docker Ubuntu ubuntu5 ubuntu) in workspace

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2512

2015-03-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2512/changes

Re: Review Request 31267: Added a test allocator module.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31267/ --- (Updated March 5, 2015, 9:05 p.m.) Review request for mesos, Kapil Arya,

Re: Review Request 31772: Fixed a bug in PosixDiskIsolator during slave recovery.

2015-03-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31772/#review75398 --- Ship it! Ship It! - Vinod Kone On March 5, 2015, 9:51 p.m., Jie

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

2015-03-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/#review75403 --- Ship it! Ship It! - Joerg Schad On March 5, 2015, 9:11 p.m.,

Build failed in Jenkins: mesos-reviewbot #4453

2015-03-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/4453/ -- [URLTrigger] A change within the response URL invocation (log) Building remotely on H10 (Ubuntu ubuntu) in workspace https://builds.apache.org/job/mesos-reviewbot/ws/ git rev-parse

Re: Review Request 31499: (3/6) Add protocol into Filter

2015-03-05 Thread Cong Wang
On March 5, 2015, 11:12 p.m., Jie Yu wrote: I don't think adding `protocol` to `Filter` is a good idea. We should keep `protocol` in `Classifier` because the `protocol` is used for classifying packets, isn't it? Regarding the basic filter, you need to something the following: ```

Re: Review Request 31499: (3/6) Add protocol into Filter

2015-03-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31499/#review75408 --- I don't think adding `protocol` to `Filter` is a good idea. We

Re: Review Request 31503: (2/6) Add the FlowId action

2015-03-05 Thread Cong Wang
On March 5, 2015, 9:57 p.m., Jie Yu wrote: src/linux/routing/filter/action.hpp, line 77 https://reviews.apache.org/r/31503/diff/2/?file=884497#file884497line77 Add a space before the colon. Also, how about calling it `action::Flow` instead of `action::FlowId`. It reads better

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #715

2015-03-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/715/changes

Jenkins build is back to normal : mesos-reviewbot #4454

2015-03-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/4454/changes

Re: Review Request 31503: (2/6) Add the FlowId action

2015-03-05 Thread Cong Wang
On March 4, 2015, 10:01 p.m., Chi Zhang wrote: src/linux/routing/filter/action.hpp, line 87 https://reviews.apache.org/r/31503/diff/1-2/?file=879070#file879070line87 could be just parent and child directly. What is mesos preferred coding style here? - Cong

Re: Review Request 31772: Fixed a bug in PosixDiskIsolator during slave recovery.

2015-03-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31772/ --- (Updated March 5, 2015, 9:51 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 31503: (2/6) Add the FlowId action

2015-03-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review75386 --- src/linux/routing/filter/action.hpp

Re: Review Request 31262: Moved allocator actions before TestAllocator.

2015-03-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31262/#review75412 --- Ship it! Ship It! - Joerg Schad On March 5, 2015, 9:05 p.m.,

Re: Mesos Community Meetings

2015-03-05 Thread Adam Bordelon
Agenda and running notes for this month's meeting are being collected in: https://docs.google.com/document/d/1BMX7M54HXFxSbaURaM0PcRQoFiflRSDtnpQN0sW-_HM/edit?usp=sharing Feel free to add any new agenda items at the bottom On Thu, Mar 5, 2015 at 1:22 PM, Dave Lester d...@davelester.org wrote:

Re: Review Request 31503: (2/6) Add the FlowId action

2015-03-05 Thread Cong Wang
On March 5, 2015, 9:57 p.m., Jie Yu wrote: src/linux/routing/filter/internal.hpp, lines 247-252 https://reviews.apache.org/r/31503/diff/2/?file=884502#file884502line247 Adjust the comments accordingly (using action 'flow' consistently). What's `Classid` in your comment?

Re: Review Request 31769: Fixed flaky MasterTest.ShutdownFrameworkWhileTaskRunning test.

2015-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31769/#review75422 --- Patch looks great! Reviews applied: [31769] All tests passed. -

Re: Review Request 31503: (2/6) Add the FlowId action

2015-03-05 Thread Cong Wang
On March 4, 2015, 10:01 p.m., Chi Zhang wrote: src/linux/routing/filter/internal.hpp, line 269 https://reviews.apache.org/r/31503/diff/1-2/?file=879075#file879075line269 Do you need to undo the previous step if this is an error? There is no way to unset a classid once we set it.

Re: Review Request 31504: (4/6) Add a basic filter to match all packets

2015-03-05 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31504/ --- (Updated March 6, 2015, 12:19 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 31505: (6/6) Add flow classifiers for fq_codel on egress

2015-03-05 Thread Cong Wang
On March 5, 2015, 1:36 a.m., Chi Zhang wrote: This is a pretty signifant feature. I am pretty sure we need a slave flag to control it. This file has examples for that. I tend to agree with Jie here, we don't want inconsistency (some has flow classifiers, some doesn't), therefore I don't

Re: Review Request 31505: (6/6) Add flow classifiers for fq_codel on egress

2015-03-05 Thread Cong Wang
On March 5, 2015, 1:36 a.m., Chi Zhang wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, line 1531 https://reviews.apache.org/r/31505/diff/2/?file=884517#file884517line1531 looks like the library code uses uint32_t here but your set is uint16_t. assuming you have

Re: Review Request 31499: (3/6) Add protocol into Filter

2015-03-05 Thread Cong Wang
On March 5, 2015, 11:12 p.m., Jie Yu wrote: I don't think adding `protocol` to `Filter` is a good idea. We should keep `protocol` in `Classifier` because the `protocol` is used for classifying packets, isn't it? Regarding the basic filter, you need to something the following: ```

Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/#review75442 --- Bad patch! Reviews applied: [31677] Failed command:

Re: Review Request 31250: Expose the number of processes and threads in a container when cgroup is enabled.

2015-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/#review75465 --- Patch looks great! Reviews applied: [31250] All tests passed. -

Re: Review Request 31664: Added operator+= and operator+ for hashmapSlaveID, Resources.

2015-03-05 Thread Alexander Rukletsov
On March 6, 2015, 3 a.m., Alexander Rukletsov wrote: src/common/resources.cpp, line 26 https://reviews.apache.org/r/31664/diff/2/?file=883420#file883420line26 Why do we need this include? Michael Park wrote: We need the `inline std::size_t hash_value(const SlaveID slaveId);`

Re: Review Request 31503: (2/6) Add the FlowId action

2015-03-05 Thread Cong Wang
On March 5, 2015, 9:57 p.m., Jie Yu wrote: src/linux/routing/filter/action.hpp, lines 83-84 https://reviews.apache.org/r/31503/diff/2/?file=884497#file884497line83 Why we need this constructor? IMO, it's not needed. We can always do the following at the callsites, right?

Re: Review Request 31505: (6/6) Add flow classifiers for fq_codel on egress

2015-03-05 Thread Cong Wang
On March 5, 2015, 1:36 a.m., Chi Zhang wrote: src/slave/containerizer/isolators/network/port_mapping.hpp, line 195 https://reviews.apache.org/r/31505/diff/2/?file=884516#file884516line195 I think we probably want to rename other counter names to account for both ingress and egree

Re: Review Request 31268: Wired up test allocator to allocator tests.

2015-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/#review75453 --- Patch looks great! Reviews applied: [31775, 31776, 31266, 31267,

Re: Review Request 31664: Added operator+= and operator+ for hashmapSlaveID, Resources.

2015-03-05 Thread Michael Park
On March 6, 2015, 3 a.m., Alexander Rukletsov wrote: src/common/resources.cpp, line 26 https://reviews.apache.org/r/31664/diff/2/?file=883420#file883420line26 Why do we need this include? We need the `inline std::size_t hash_value(const SlaveID slaveId);` from it for

Re: Review Request 30841: Remove static strings and split process.cpp

2015-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30841/#review75449 --- Patch looks great! Reviews applied: [30841] All tests passed. -

Re: Review Request 31664: Added operator+= and operator+ for hashmapSlaveID, Resources.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31664/#review75452 --- src/common/resources.cpp

Re: Review Request 31499: (3/6) Add protocol into Filter

2015-03-05 Thread Jie Yu
On March 5, 2015, 11:12 p.m., Jie Yu wrote: I don't think adding `protocol` to `Filter` is a good idea. We should keep `protocol` in `Classifier` because the `protocol` is used for classifying packets, isn't it? Regarding the basic filter, you need to something the following: ```

Re: Review Request 31499: (3/6) Add protocol into Filter

2015-03-05 Thread Jie Yu
On March 5, 2015, 11:12 p.m., Jie Yu wrote: I don't think adding `protocol` to `Filter` is a good idea. We should keep `protocol` in `Classifier` because the `protocol` is used for classifying packets, isn't it? Regarding the basic filter, you need to something the following: ```

Re: Review Request 31499: (3/6) Add protocol into Filter

2015-03-05 Thread Jie Yu
On March 5, 2015, 11:12 p.m., Jie Yu wrote: I don't think adding `protocol` to `Filter` is a good idea. We should keep `protocol` in `Classifier` because the `protocol` is used for classifying packets, isn't it? Regarding the basic filter, you need to something the following: ```

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review75436 --- Patch looks great! Reviews applied: [27760] All tests passed. -

Re: Review Request 31499: (3/6) Add protocol into Filter

2015-03-05 Thread Cong Wang
On March 5, 2015, 11:12 p.m., Jie Yu wrote: I don't think adding `protocol` to `Filter` is a good idea. We should keep `protocol` in `Classifier` because the `protocol` is used for classifying packets, isn't it? Regarding the basic filter, you need to something the following: ```

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Evelina Dumitrescu
On March 3, 2015, 6:39 p.m., Jie Yu wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 62 https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line62 `struct in_addr` stores ip address in network order by standard. No need to mention that in the

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Evelina Dumitrescu
On March 3, 2015, 5:06 p.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 108 https://reviews.apache.org/r/31471/diff/4/?file=882870#file882870line108 why did this change? sorry for that, I accidentally used an old version of net.hpp -

Re: Review Request 30774: Fetcher Cache

2015-03-05 Thread Bernd Mathiske
On March 4, 2015, 4:39 p.m., Jay Buffington wrote: Hey Bernd, I'm really looking forward to this feature. There's a lot here, so I was hoping you could help me understand by responding to some of these questions: Why do you need the cache table data structure? Just use the

Re: Review Request 29550: Libprocess: Added tests target for make.

2015-03-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29550/#review75352 --- Ship it! Ship It! - Till Toenshoff On Jan. 26, 2015, 11:09

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31538/#review75353 --- src/slave/slave.cpp

Re: Review Request 31724: Replace hardcoded constants from libprocess with INADDR_ANY and INADDR_LOOPBACK

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31724/ --- (Updated March 5, 2015, 10:07 a.m.) Review request for mesos, Dominic Hamon

Re: Review Request 31470: stout: Introduce IPNetwork class to encapsulate an IP address and netmask.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31470/ --- (Updated March 5, 2015, 3:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29290: mesos: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29290/ --- (Updated March 5, 2015, 3:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/#review75351 --- Bad patch! Reviews applied: [31677] Failed command:

Re: Review Request 31324: Updated changelog for 0.22.0

2015-03-05 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31324/#review75312 --- CHANGELOG https://reviews.apache.org/r/31324/#comment122301

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31538/ --- (Updated March 5, 2015, 11:02 a.m.) Review request for mesos, Isabel Jimenez,

Re: Review Request 31472: stout: Make fromLinkDevice method member of the IPNetwork class.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31472/ --- (Updated March 5, 2015, 3:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31471/ --- (Updated March 5, 2015, 4:06 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29288: stout: Extend the IP and IPNetwork classes to support IPv6.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/ --- (Updated March 5, 2015, 4:06 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29288: stout: Extend the IP and IPNetwork classes to support IPv6.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/ --- (Updated March 5, 2015, 3:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/ --- (Updated March 5, 2015, 3:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 31473: mesos: Make fromLinkDevice method member of the IPNetwork class.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31473/ --- (Updated March 5, 2015, 3:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

2015-03-05 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31471/ --- (Updated March 5, 2015, 3:46 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 31769: Fixed flaky MasterTest.ShutdownFrameworkWhileTaskRunning test.

2015-03-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31769/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-2401

Re: Review Request 31250: Expose the number of processes and threads in a container when cgroup is enabled.

2015-03-05 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/#review75370 --- Ship it! src/tests/isolator_tests.cpp

Re: Review Request 31724: Replace hardcoded constants from libprocess with INADDR_ANY and INADDR_LOOPBACK

2015-03-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31724/#review75322 --- Ship it! Ship It! - Alexander Rojas On March 4, 2015, 9:37

Re: Review Request 30774: Fetcher Cache

2015-03-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated March 5, 2015, 3:15 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31538/#review75317 --- Patch looks great! Reviews applied: [31538] All tests passed. -

Re: Review Request 29550: Libprocess: Added tests target for make.

2015-03-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29550/#review75324 --- Ship it! Ship It! - Alexander Rojas On Jan. 27, 2015, 12:09

Apache Mesos Community Sync

2015-03-05 Thread Vinod Kone via Blue Jeans Network
BEGIN:VCALENDAR VERSION:2.0 METHOD:REQUEST PRODID:-//PYVOBJECT//NONSGML Version 1//EN BEGIN:VTIMEZONE TZID:America/Los_Angeles TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZOFFSETFROM:-0800 TZOFFSETTO:-0700 TZNAME:PDT

Review Request 31784: type_utils: Relaxened the equality check of CommandInfo to allow 'unset' environment == 'empty' environment.

2015-03-05 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31784/ --- Review request for mesos, Alexander Rukletsov, Joerg Schad, Till Toenshoff,

Re: Review Request 31250: Expose the number of processes and threads in a container when cgroup is enabled.

2015-03-05 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/ --- (Updated March 6, 2015, 2 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 31183: Factored out sum function for Resources.

2015-03-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31183/#review75451 --- include/mesos/resources.hpp

Re: Review Request 31784: type_utils: Relaxened the equality check of CommandInfo to allow 'unset' environment == 'empty' environment.

2015-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31784/#review75458 --- Patch looks great! Reviews applied: [31784] All tests passed. -

Review Request 31790: added presentation on building and deploying, on 26 Feb 2015

2015-03-05 Thread Nancy Ko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31790/ --- Review request for mesos. Bugs: MESOS-2444