Re: Review Request 31539: Remove the checkpoint variable entirely from slave/flags.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31539/#review76502 --- First pass looks good. I've got a couple of questions about the

Re: Review Request 31539: Remove the checkpoint variable entirely from slave/flags.hpp.

On March 2, 2015, 11:39 a.m., Cody Maloney wrote: src/tests/master_allocator_tests.cpp, line 637 https://reviews.apache.org/r/31539/diff/2/?file=882281#file882281line637 The test shouldn't be deleted, rather updated to make sure that after the timeout of a slave being really

executor source not set

Is there a reason that the native executor driver bindings don't check for/enforce a TaskStatus.Source of SOURCE_EXECUTOR? https://github.com/apache/mesos/blob/master/src/exec/exec.cpp#L490 Or is that supposed to be handled somewhere else? -James

Re: executor source not set

Yes, generated by the executor. I do see a source for status updates generated by reconciliation processes. For example: reason=REASON_RECONCILIATION,source=SOURCE_MASTER,state=TASK_RUNNING But for status updates generated by my executor, the scheduler sees this:

Re: executor source not set

Ah crap. You are right! Please file a JIRA. We should have a test for this. On Sun, Mar 15, 2015 at 8:05 PM, James DeFelice james.defel...@gmail.com wrote: Vinod, I suspect that the status.set_source is meaningless since it's likely updating an object that's a copy of what's actually inside

Re: How to sizing memory in mesos

There's also the previously discussed ResizeTask primitive: https://issues.apache.org/jira/browse/MESOS-1279 Yifan wrote an initial proof-of-concept patch that could probably be resurrected and cleaned up. On Fri, Mar 13, 2015 at 2:28 PM, Tim St Clair tstcl...@redhat.com wrote: fwiw - other

Re: executor source not set

Thanks, I found the same. For some reason I'm not seeing a Source set in the updates that the scheduler is receiving. The updates are being generated via the mesos-go bindings. The bindings shouldn't matter since the slave is supposed to fill in the blank. Not sure what's going on, needs more

Re: executor source not set

It is enforced by the slave to be future proof (a future where there will be no executor driver). https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L2491 On Sun, Mar 15, 2015 at 11:45 AM, James DeFelice james.defel...@gmail.com wrote: Is there a reason that the native executor

Re: executor source not set

Are these updates generated by the executor? Note that updates *generated* by slave or master will have a different source. Are you not seeing any source at all in the updates? On Sun, Mar 15, 2015 at 6:59 PM, James DeFelice james.defel...@gmail.com wrote: Thanks, I found the same. For some

Re: executor source not set

Vinod, I suspect that the status.set_source is meaningless since it's likely updating an object that's a copy of what's actually inside the StatusUpdate that's forward()ed from the slave. In the master code, I see references to things like message.mutable_update().mutable_status() that seem obtain