On March 18, 2015, 11:04 p.m., Adam B wrote:
(Sorry, pulled the trigger early; meant to click Save instead. More coming..)
- Adam
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review77019
---
src/slave/containerizer/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review77025
---
src/slave/containerizer/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review77020
---
src/tests/master_authorization_tests.cpp
On March 18, 2015, 11:05 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 406
https://reviews.apache.org/r/30774/diff/37/?file=897704#file897704line406
Do we call fetch even if we don't have anything to fetch? I think it
will be a good idea to have a fast
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review77022
---
Ship it!
LGTM! Just some comments about comments, and then I'd be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated March 18, 2015, 11:43 p.m.)
Review request for mesos, Adam B,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28485/#review77122
---
3rdparty/libprocess/include/process/address.hpp
in EMPTY status
I0319 23:56:32.749831 18618 recover.cpp:566] Updating replica status to STARTING
I0319 23:56:32.749951 18612 master.cpp:358] Master
20150319-235632-3176252227-48061-18582 (proserpina.apache.org) started on
67.195.81.189:48061
I0319 23:56:32.75 18612 master.cpp:404] Master only
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/#review77123
---
Ship it!
- Jie Yu
On March 7, 2015, 6:56 a.m., Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31930/#review77118
---
Patch looks great!
Reviews applied: [31930]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated March 19, 2015, 10:48 p.m.)
Review request for mesos, Adam B,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31986/#review77159
---
LGTM
- Bernd Mathiske
On March 13, 2015, 8:21 a.m., Alexander
On March 19, 2015, 3:11 p.m., Bernd Mathiske wrote:
src/slave/containerizer/external_containerizer.cpp, line 239
https://reviews.apache.org/r/32233/diff/2/?file=899898#file899898line239
dispatch(process.get(),
ExternalContainerizerProcess::destroy,
See https://builds.apache.org/job/mesos-reviewbot/4691/
--
[...truncated 5587 lines...]
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.23.0/_build/src'
Making distclean in ec2
make[2]: Entering directory
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29541/#review77068
---
@benh: is this still relevant?
- Joris Van Remoortere
On Jan.
See https://builds.apache.org/job/mesos-reviewbot/4692/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/
---
(Updated March 19, 2015, 1:47 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276/#review76978
---
Much better!
src/Makefile.am
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28254/#review77067
---
@cmaloney: can you add reviewers or drop this issue please?
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28254/#review77073
---
Interesting change cody? Are you still looking to get this in?
I'm
On March 19, 2015, 4:33 p.m., Adam B wrote:
src/tests/fault_tolerance_tests.cpp, line 123
https://reviews.apache.org/r/31539/diff/7-8/?file=899402#file899402line123
No need to call it a checkpointing slave, since all slaves are
checkpointing now.
Joerg Schad wrote:
Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review77074
---
Take this all with plenty of salt since I really haven't figured
+1
On Wed, Mar 18, 2015 at 3:52 PM, Niklas Nielsen nik...@mesosphere.io
wrote:
Hi all,
Please vote on releasing the following candidate as Apache Mesos 0.22.0.
0.22.0 includes the following:
* Support for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77046
---
Patch looks great!
Reviews applied: [32233]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32150/
---
(Updated March 19, 2015, 7:06 p.m.)
Review request for mesos, Alexander
On March 19, 2015, 9:40 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 379
https://reviews.apache.org/r/30774/diff/38/?file=899705#file899705line379
benh, what do you think of Bernd's contentionBarrier injection?
commonly we always just mock the callback
On Feb. 25, 2015, 10:56 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 528
https://reviews.apache.org/r/30774/diff/19/?file=875881#file875881line528
return size.error();
Bernd Mathiske wrote:
That does not compile.
Timothy Chen wrote:
It doesn't?
On Feb. 25, 2015, 10:30 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 686
https://reviews.apache.org/r/30774/diff/19/?file=875881#file875881line686
Seems like lookupEntry is only used here, and it's always coupled with
a reference call.
How
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28485/
---
(Updated March 19, 2015, 7:23 p.m.)
Review request for mesos, Benjamin Hindman
On March 19, 2015, 6:06 p.m., Ben Mahler wrote:
Interesting change cody? Are you still looking to get this in?
I'm hoping we can clean up the current design of http::get and http::post,
where the function arguments have essentially grown to be subsets of things
inside the 'Request'
On Feb. 24, 2015, 11:26 p.m., Timothy Chen wrote:
docs/fetcher.md, line 68
https://reviews.apache.org/r/30774/diff/17/?file=872869#file872869line68
Not sure if putting the struct here is a good idea, as it's most likely
going to be changed in the future.
Bernd Mathiske wrote:
On March 18, 2015, 11:05 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 503
https://reviews.apache.org/r/30774/diff/37/?file=897704#file897704line503
Since this is only called in one place, how about put this in ___fetch,
pass it the future and check if it
+1 (non-binding)
Mac OS 10.9.5 + clang
CentOS 7 + gcc 4.4.7 [cgroups tests disabled]
On Wed, Mar 18, 2015 at 4:04 PM, Brenden Matthews bren...@diddyinc.com
wrote:
+1
Tested with internal testing cluster.
On Wed, Mar 18, 2015 at 1:25 PM, craig w codecr...@gmail.com wrote:
+1
On Wed, Mar
Folks,
For those who are interested, going to make the push now for getting Mesos into
epel ( https://fedoraproject.org/wiki/EPEL ) 7 and by extension all the clones
and variants.
https://bugzilla.redhat.com/show_bug.cgi?id=1177055
Luckily just by waiting a while, the dep-graph has shrunk.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30546/#review77084
---
src/slave/containerizer/isolators/cgroups/mem.cpp
On March 18, 2015, 11:49 p.m., Jie Yu wrote:
3rdparty/libprocess/include/process/http.hpp, lines 167-186
https://reviews.apache.org/r/31930/diff/2/?file=896914#file896914line167
Instead of keeping a reference to Data, wouldn't be simpler and more
straitforward to keep a Pipe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31930/
---
(Updated March 19, 2015, 9:33 p.m.)
Review request for mesos, Benjamin
On March 18, 2015, 11:49 p.m., Jie Yu wrote:
3rdparty/libprocess/src/process.cpp, lines 1149-1151
https://reviews.apache.org/r/31930/diff/2/?file=896916#file896916line1149
Does this comment still apply? Looks like we cannot write empty string.
Maybe a CHECK?
Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review77054
---
Patch looks great!
Reviews applied: [31539]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/
---
(Updated March 19, 2015, 3:52 p.m.)
Review request for mesos, Adam B, Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77047
---
src/slave/containerizer/external_containerizer.cpp
On March 18, 2015, 11:48 p.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 726
https://reviews.apache.org/r/30774/diff/37/?file=897704#file897704line726
I'm not sure I understand, the error is never logged and in the end we
simply return 0 if os::find returns a
On March 19, 2015, 6:33 a.m., Adam B wrote:
src/tests/master_allocator_tests.cpp, line 707
https://reviews.apache.org/r/31539/diff/7/?file=899404#file899404line707
Should this line also get a comment explaining why shutdown=true?
Done (+ fixed style issue)
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review77055
---
Ship it!
Looks great! I'll try to get this committed later today,
On March 19, 2015, 4:33 p.m., Adam B wrote:
src/tests/fault_tolerance_tests.cpp, line 123
https://reviews.apache.org/r/31539/diff/7-8/?file=899402#file899402line123
No need to call it a checkpointing slave, since all slaves are
checkpointing now.
Till was initially wondering why
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review77057
---
src/slave/containerizer/fetcher.cpp
On March 19, 2015, 9:33 a.m., Adam B wrote:
src/tests/fault_tolerance_tests.cpp, line 123
https://reviews.apache.org/r/31539/diff/7-8/?file=899402#file899402line123
No need to call it a checkpointing slave, since all slaves are
checkpointing now.
Joerg Schad wrote:
Till
48 matches
Mail list logo
