Re: Oversubscription design doc

2015-04-22 Thread Dave Lester
The idea of using a separate IRC channel to discuss this sounds fine by me, but it'd be valuable to have this also logged by ASFbot, similar to how #mesos is logged so folks can catch up. Could someone file an INFRA ticket? Shouldn't be too hard to set up. On Wed, Apr 22, 2015, at 03:34 PM, Vinod

Re: Oversubscription design doc

2015-04-22 Thread Vinod Kone
Broke down the epic https://issues.apache.org/jira/browse/MESOS-354 into tasks per earlier discussions. Feel free to edit / break down further. On Tue, Apr 14, 2015 at 11:22 AM, Joris Van Remoortere wrote: > We have a dedicated IRC channel for this: "mesos-oversubscription". Feel > free to drop

Re: Suggestion: Mesos 0.22.1 point release

2015-04-22 Thread Benjamin Mahler
Linked it with the release ticket as a blocker. The fix is committed. On Wed, Apr 22, 2015 at 2:53 PM, Benjamin Mahler wrote: > One regression in 0.22.x we missed: > https://issues.apache.org/jira/browse/MESOS-2643 > > Here, the python bindings are not backwards compatible in that they > disabl

Re: Suggestion: Mesos 0.22.1 point release

2015-04-22 Thread Benjamin Mahler
One regression in 0.22.x we missed: https://issues.apache.org/jira/browse/MESOS-2643 Here, the python bindings are not backwards compatible in that they disable implicit acknowledgements by default. The fix is trivial, and I have a review linked below. Can we get this in 0.22.1? https://reviews.a

Re: statusUpdate always RUNNING even after job has finished

2015-04-22 Thread Benjamin Mahler
That's a bug, the default should have been backwards compatible. Sorry for that! It's a trivial fix, Alex, can we get the fix in 0.22.1? https://issues.apache.org/jira/browse/MESOS-2643 I'll send a fix shortly. On Wed, Apr 22, 2015 at 12:42 AM, Alexander Rojas wrote: > Hey Zack, > > Which valu

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/#review81202 --- Patch looks great! Reviews applied: [33271, 33274, 33276] All test

Re: Using boost filesystem

2015-04-22 Thread Cody Maloney
It's not header only. I think we actually need a general discussion around upgrading all the libraries mesos depends upon (Using a plain up-stream boost, etc). Note that some portions of stout already require callers to link against specific libraries for them to actually work, so I don't think t

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33109/#review81195 --- Patch looks great! Reviews applied: [33109] All tests passed. - M

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33109/ --- (Updated April 22, 2015, 5:38 p.m.) Review request for mesos and Adam B. Bugs

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review81180 --- Bad patch! Reviews applied: [29327, 29328] Failed command: ./suppo

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33109/ --- (Updated April 22, 2015, 5:37 p.m.) Review request for mesos and Adam B. Bugs

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33109/ --- (Updated April 22, 2015, 5:35 p.m.) Review request for mesos and Adam B. Bugs

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-04-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/ --- (Updated April 22, 2015, 5:33 p.m.) Review request for mesos and Benjamin Hindm

Re: Splitting reviews and build emails into their own mailing lists

2015-04-22 Thread Vinod Kone
i also cut over build emails to bui...@mesos.apache.org also, took the opportunity to delete all our various jenkins jobs in favor of the new "Mesos" job . On Wed, Apr 22, 2015 at 10:08 AM, Jake Farrell wrote: > Reviewboard has been cut over to

Re: Splitting reviews and build emails into their own mailing lists

2015-04-22 Thread Jake Farrell
Reviewboard has been cut over to now use revi...@mesos.apache.org -Jake On Mon, Apr 20, 2015 at 7:34 PM, Vinod Kone wrote: > OK, we have got the following email lists setup (h/t Jake Farrell). > > revi...@mesos.apache.org -- By wednesday (04/22) all emails from Review > Board will go here and

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33109/ --- (Updated April 22, 2015, 4:47 p.m.) Review request for mesos and Adam B. Bugs

Re: Review Request 33090: Removed unmaintained frameworks code.

2015-04-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33090/#review81173 --- Should you also remove ``docs/using-the-mesos-submit-tool.md``? - J

Re: Using boost filesystem

2015-04-22 Thread Vinod Kone
Is it header only? On Wed, Apr 22, 2015 at 2:31 AM, Alexander Rojas wrote: > Hey guys, > > I was checking one of my reviews which call for using some unimplemented > functionality in stout path. Since that class has no methods, attributes or > anything apart from a string value attribute; I was

Re: statusUpdate always RUNNING even after job has finished

2015-04-22 Thread Zack Booth Simpson
Hi Alex, I think I talked to you on IRC the other day. Thanks for responding. Yes, the problem was the implicitAknowledge default is backwards in the python bindings I have. I still think (but haven't yet verified) that I have some weird conflicting python egg. I'll reinstall from scratch at some

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-04-22 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review81165 --- Ship it! Ship It! - Marco Massenzio On April 22, 2015, 6:21 a.m.

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/#review81160 --- Patch looks great! Reviews applied: [33295, 33296] All tests passe

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-04-22 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/ --- (Updated April 22, 2015, 4:36 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-04-22 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated April 22, 2015, 4:35 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review81139 --- Looks good to me, MPark. Several high-level questions (some of them

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/#review81148 --- Ship it! Modulo Tim's and Jie's comments. - Alexander Rukletsov

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/#review81143 --- src/common/resources.cpp

Re: Review Request 32139: Added 'Resource::ReservationInfo' protobuf message.

2015-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32139/#review81140 --- Ship it! include/mesos/mesos.proto

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-22 Thread Alexander Rukletsov
> On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 69-74 > > > > > > Not yours, but resently, Vinod did a cleanup in equivalence operators > > for our proto messages in `typ

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

2015-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/#review81137 --- Patch looks great! Reviews applied: [33358] All tests passed. - M

Using boost filesystem

2015-04-22 Thread Alexander Rojas
Hey guys, I was checking one of my reviews which call for using some unimplemented functionality in stout path. Since that class has no methods, attributes or anything apart from a string value attribute; I was left wondering, wether it makes sense to use boost filesystem. Boost filesystem v3

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

2015-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/#review81136 --- Ship it! Let's not repeat summary in description. How about the fol

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

2015-04-22 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/ --- (Updated April 22, 2015, 11:09 a.m.) Review request for mesos, Alexander Ruklet

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-04-22 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/#review81133 --- This doc looks great now, so let's update upgrades.md too. docs/mo

Re: statusUpdate always RUNNING even after job has finished

2015-04-22 Thread Alexander Rojas
Hey Zack, Which value are you for the setting implicitAknowledge parameter in the SchedulerDriver constructor? if it is set to false, you will have to manually knowledge every statusUpdate, otherwise the executor will try to retry. Are you using the python bindings? It seems that the default va

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review81131 --- Patch looks great! Reviews applied: [32198, 32163, 30612] All test