Re: Proposal for Mesos Build Improvements

On Wed, Feb 15, 2017 at 1:59 PM, Jeff Coffler wrote: > 3. Maintaining the correct includes is nice, but not at the cost of compiler > speed. Personally, I would invert these statements -- but until we know the cost of the redundant includes, probably not

RE: Proposal for Mesos Build Improvements

I'm planning on prototyping this just to generate numbers. I don't think I need permission to do that! But, of course, to incorporate any changes into the code base, we need consensus. I agree that stout optimizations are outside of the scope of this discussion. Any stout optimizations are

Re: Proposal for Mesos Build Improvements

Hi, > I wonder if we should instead use headers like: > > <- mesos_common.h -> > #include > #include > #include > > <- xyz.cpp, which needs headers "b" and "d" -> > #include "mesos_common.h> > > #include > #include > > That way, the fact that "xyz.cpp" logically depends on (but not >

Re: Proposal for Mesos Build Improvements

Thanks Jeff for the proposal! Faster builds for Mesos have been a long awaited feature, so great to see some real traction here. Regarding benchmarks, would it be possible to have benchmarks (for clean build and incremental build) with 1) PCH only change 2) stout non-header-only and 3) 1+2 ? Not

RE: Proposal for Mesos Build Improvements

Ni Neil, What you're saying is essentially correct. If mesos_common.h includes a bunch of, well, "common" stuff, and everybody includes mesos_common.h, then those files will, by definition, have a least some number of items that they didn't need. Since PCH works on both Windows and Linux, I

Re: Proposal for Mesos Build Improvements

Yes, that is right, PCHs would probably introduce some additional dependencies for some object files, and if those PCHs become bloated over time, then you can expect this to be expressed as diminishing time savings. This does imply that maintaining PCHs will require at least some work. __

Re: Proposal for Mesos Build Improvements

On Tue, Feb 14, 2017 at 11:28 AM, Jeff Coffler wrote: > For efficiency purposes, if a header file is included by 50% or more of the > source files, it should be included in the precompiled header. If a header is > included in fewer than 50% of the source

Re: Proposal for Mesos Build Improvements

> > However, the non-header-only work won't do anything in a "clean build" > scenario. I don't think this is true. If you look at how many independent .o files we build that scan those headers each time it should be clear that reducing the complexity of the header file reduces the compile time.

Re: Image pre-fetching API

Commented. @vinodkone > On Feb 15, 2017, at 9:21 AM, Jie Yu wrote: > > Vinod and Anand, > > IIya Pronin is working on adding an agent operator API for pre-fetching > images. > https://issues.apache.org/jira/browse/MESOS-2824 > > Can you guys comment on the API proposal