Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/23#discussion_r15443932
--- Diff: src/master/flags.hpp ---
@@ -61,7 +61,8 @@ class Flags : public logging::Flags
add(Flags::work_dir,
work_dir
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/181#discussion_r89031974
--- Diff: docs/frameworks.md ---
@@ -30,6 +30,7 @@ layout: documentation
* [Chronos](https://github.com/mesos/chronos) is a distributed job
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/179#discussion_r89030359
--- Diff: docs/home.md ---
@@ -109,6 +109,11 @@ layout: documentation
+https://www.packtpub.com/big-data-and-business-intelligence
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/179#discussion_r89031027
--- Diff: docs/home.md ---
@@ -109,6 +109,11 @@ layout: documentation
+https://www.packtpub.com/big-data-and-business-intelligence
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/179
I pushed this with some minor changes to make it consistent with the other
entries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/233
Thanks janisz, this looks pretty good. However, this needs to be added to
several places:
- The global tasks table (you covered this)
- The framework-specific task table (when clicking
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/234#discussion_r140382123
--- Diff: src/webui/master/static/js/controllers.js ---
@@ -230,6 +230,34 @@
_.each(framework.unreachable_tasks, setTaskMetadata
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/234#discussion_r140382041
--- Diff: src/webui/master/static/js/controllers.js ---
@@ -230,6 +230,34 @@
_.each(framework.unreachable_tasks, setTaskMetadata
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/233#discussion_r142247472
--- Diff: src/webui/master/static/js/app.js ---
@@ -88,6 +88,14 @@
return state.substring(5);
};
})
+.filter
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/233#discussion_r142247344
--- Diff: src/webui/master/static/js/controllers.js ---
@@ -838,6 +839,15 @@
});
}
+ function setHealth
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/233
@janisz I noticed you updated the patch, is it ready for another review?
Would be great to keep the colors as you had before. I was just asking about
the approach used :)
Also can you add
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/245
Thanks @deric!
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/244
Thanks @bobeckert! This is now committed.
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/285
What were the errors?
---
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/256#discussion_r161334491
--- Diff: docs/endpoints/files/browse.json.md ---
@@ -20,7 +20,7 @@ Query parameters:
### AUTHENTICATION ###
-This endpoint requires
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/249
Thanks, can you close this PR in favor of that one?
---
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/256#discussion_r161334849
--- Diff: docs/app-framework-development-guide.md ---
@@ -91,13 +91,13 @@ virtual void offerRescinded(SchedulerDriver* driver,
const OfferID& off
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/253
No worries! I just realized that the tooling left behind some dirty state
and these changes were pulled into the next PR I committed:
370b5b634d1132a34022ec184a3056de46b45c4a.
Sorry about
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/256#discussion_r161337083
--- Diff: docs/endpoints/files/browse.json.md ---
@@ -20,7 +20,7 @@ Query parameters:
### AUTHENTICATION ###
-This endpoint requires
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/256
Hm.. I'm unable to pull the patch down:
```
$ ./support/apply-reviews.py -g 256
Cookie coming from patch-diff.githubusercontent.com attempted to set domain
to github.com
2018-01
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/256
Sorry about that, and thank you for your patience!
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/256
Hm.. I don't know if I'm looking at this right, but when I click 'Files
Changed' I still see the "iff" and "acknowledgements" adjustments, so I wonder
if your update took effect o
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/262
@mpark I didn't realize we also supported setting role within
`reservation`, should this be adding to `reservations`? Or do we officially
support `reservation` with type `DYNAMIC` & `role`?
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/249
@packtpartner can you add this under a new 'Training' section at the bottom?
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/249
Perhaps we need to introduce a paid section in this page for this type of
content? Other PMC members have thoughts here?
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/302
Thanks @thzois!
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/266
We've removed these docs entirely from the repo since they were very stale
and they now get generated as part of the website publishing, you can find them
here:
http://mesos.apache.org
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/266
@kohend can you close this PR based on my comment above?
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/284
We should try to fix apply-reviews.py. Looks related to this discussion?
https://bugs.python.org/issue1759845
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/284
@clems4ever can you post the error? Is this an issue in `rbt` or our python
wrapper script?
---
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/266
@kohend Can you clarify? I'm not sure what you mean.
---
31 matches
Mail list logo
