Github user xujyan commented on the pull request:
https://github.com/apache/mesos/commit/a1b86051d3d9120b8ef00a3e3ac18786a630dd76#commitcomment-20769217
In src/master/allocator/mesos/hierarchical.cpp:
In src/master/allocator/mesos/hierarchical.cpp on line 682:
Doesn't look
Github user xujyan commented on a diff in the pull request:
https://github.com/apache/mesos/pull/287#discussion_r185338798
--- Diff: docs/contributors.yaml ---
@@ -769,6 +769,15 @@
- xia...@gmail.com
jira_user: xds2000
reviewboard_user: xds2000
Github user xujyan commented on a diff in the pull request:
https://github.com/apache/mesos/pull/279#discussion_r179548772
--- Diff: src/master/master.cpp ---
@@ -10046,6 +10060,21 @@ void Master::__removeSlave(
unreachable = false;
newTaskState
Github user xujyan commented on a diff in the pull request:
https://github.com/apache/mesos/pull/279#discussion_r179539166
--- Diff: src/master/master.hpp ---
@@ -1913,6 +1913,10 @@ class Master : public ProtobufProcess
// `registry_max_agent_age
Github user xujyan commented on a diff in the pull request:
https://github.com/apache/mesos/pull/279#discussion_r179547033
--- Diff: src/master/master.cpp ---
@@ -6843,6 +6846,17 @@ void Master::__reregisterSlave(
recoveredTasks.push_back(std::move(task
Github user xujyan commented on a diff in the pull request:
https://github.com/apache/mesos/pull/279#discussion_r179542793
--- Diff: src/master/master.cpp ---
@@ -6792,6 +6793,7 @@ void Master::__reregisterSlave(
// master (those tasks were previously marked "unreac
Github user xujyan commented on a diff in the pull request:
https://github.com/apache/mesos/pull/279#discussion_r179546249
--- Diff: src/master/master.cpp ---
@@ -6805,6 +6807,7 @@ void Master::__reregisterSlave(
Framework* framework = getFramework(frameworkId
Github user xujyan commented on the issue:
https://github.com/apache/mesos/pull/279
@Gilbert88: @m9a was having difficulty in with rbt so I told her to use a
PR. Let's see how it goes first. @m9a have you created a JIRA and are you able
to set the reviewer so it's clear to everyone
Github user xujyan commented on the issue:
https://github.com/apache/mesos/pull/280
Thanks for @carlonelong for the PR. The PR includes some extraneous commits
(see above), could you clean it up?
---
