[GitHub] mesos issue #280: Fix wrong example of executor message.

2018-04-04 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/280 LGTM! I committed this patch with commit message modified. ---

[GitHub] mesos issue #279: WIP: Remove unknown unreachable tasks when agent re-regist...

2018-03-31 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/279 Hi @m9a , thanks for the PR. While the issue is still in WIP stage. Would you mind to create a [JIRA-where people track on issues](https://issues.apache.org/jira/projects/MESOS) and post a patch

[GitHub] mesos issue #269: fix name of --executor_environment_variables

2018-03-12 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/269 @benjaminp Could you close this PR as it has got merged? ---

[GitHub] mesos issue #270: Update presentations.md

2018-03-12 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/270 commit f5f7ec0d0c6db166bfc5e76af3e3ab2a31e5b625 Author: Benjamin Peterson <benja...@python.org> Date: Sun Mar 11 23:02:17 2018 -0700 Fix link to zookeeper documentation. ---

[GitHub] mesos issue #269: fix name of --executor_environment_variables

2018-03-12 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/269 commit d863d61b281ecfe6bb27325a90f4e84881e8cfd6 Author: Benjamin Peterson <benja...@python.org> Date: Mon Mar 5 22:02:26 2018 -0800 fix name of --executor_environment_var

[GitHub] mesos issue #269: fix name of --executor_environment_variables

2018-03-06 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/269 LGTM! Ship it! ---

[GitHub] mesos issue #263: Allow nested containers in pods to have separate namespace...

2018-02-20 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/263 A quick note that we could have a followup patch to add documents here: http://mesos.apache.org/documentation/latest/containerizer-internals/#linux-namespaces ---

[GitHub] mesos issue #221: Fixed a bug in the logging of cni isolator.

2018-01-24 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/221 @haoyixin Could you close this PR in favor of https://reviews.apache.org/r/65306/ ---

[GitHub] mesos issue #141: Fix FrameworkInfo::user documentation

2016-07-15 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/141 Thanks for the clarification @ktf . This patch LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does