Github user qianzhangxa commented on a diff in the pull request:
https://github.com/apache/mesos/pull/299#discussion_r197734403
--- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
@@ -428,6 +428,10 @@ Future NetworkCniIsolatorProcess::recover
Github user qianzhangxa commented on a diff in the pull request:
https://github.com/apache/mesos/pull/299#discussion_r197723561
--- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
@@ -428,6 +428,10 @@ Future NetworkCniIsolatorProcess::recover
Github user qianzhangxa commented on a diff in the pull request:
https://github.com/apache/mesos/pull/299#discussion_r197723026
--- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
@@ -428,6 +428,10 @@ Future NetworkCniIsolatorProcess::recover
Github user qianzhangxa commented on the pull request:
https://github.com/apache/mesos/commit/5b2261409e2b391d9182c5579e1df481c7f0779f#commitcomment-28653741
OK, I see, thanks @shuizz.
---
Github user qianzhangxa commented on the pull request:
https://github.com/apache/mesos/commit/5b2261409e2b391d9182c5579e1df481c7f0779f#commitcomment-28632280
@shuizz Can you please post the json here? I'd like to take a look, thanks!
---
Github user qianzhangxa commented on the pull request:
https://github.com/apache/mesos/commit/5b2261409e2b391d9182c5579e1df481c7f0779f#commitcomment-28615233
@shuizz `protobuf::internal::parse(google::protobuf::Message* message,
const JSON::Object& object)` is used to convert a
Github user qianzhangxa commented on the issue:
https://github.com/apache/mesos/pull/263
I'd like to echo @jdef's comment, we need a clear use case for ip per
nested container. Our current status is, if framework launches multiple task
groups (pods) via a single default executor, all
Github user qianzhangxa commented on the issue:
https://github.com/apache/mesos/pull/221
This PR can be closed in favour of https://reviews.apache.org/r/65306/.
---
