[GitHub] mesos issue #248: Fix master validation, incorrect detection of dup Executor...

2017-11-03 Thread abudnik
Github user abudnik commented on the issue: https://github.com/apache/mesos/pull/248 If some framework relies on the assumption that there shouldn't be multiple executors running with the same executor_id on the same agent, then this change might lead to bugs. It would be great

[GitHub] mesos issue #248: Fix master validation, incorrect detection of dup Executor...

2017-11-03 Thread jdef
Github user jdef commented on the issue: https://github.com/apache/mesos/pull/248 @abudnik the master.hpp code you cited is already scoped to Framework. I don't think we need to change anything there. ---

[GitHub] mesos issue #248: Fix master validation, incorrect detection of dup Executor...

2017-11-03 Thread abudnik
Github user abudnik commented on the issue: https://github.com/apache/mesos/pull/248 Should we also update comment https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L78-L82 ? ---

[GitHub] mesos issue #248: Fix master validation, incorrect detection of dup Executor...

2017-11-03 Thread abudnik
Github user abudnik commented on the issue: https://github.com/apache/mesos/pull/248 We should also update here https://github.com/apache/mesos/blob/master/src/master/master.hpp#L2665-L2667 and maybe in other places, where master/agent checks for duplicate executor ids. ---

[GitHub] mesos issue #248: Fix master validation, incorrect detection of dup Executor...

2017-11-03 Thread jdef
Github user jdef commented on the issue: https://github.com/apache/mesos/pull/248 https://issues.apache.org/jira/browse/MESOS-8169 ---

[GitHub] mesos issue #248: Fix master validation, incorrect detection of dup Executor...

2017-11-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/mesos/pull/248 @jdef Good find! Can you please make a JIRA for this? ---

[GitHub] mesos issue #248: Fix master validation, incorrect detection of dup Executor...

2017-11-03 Thread jdef
Github user jdef commented on the issue: https://github.com/apache/mesos/pull/248 @jpeach it looks like you were in here recently, what are your thoughts on this? ---