[GitHub] mesos pull request: Upgrade zookeeper to 3.4.8.

[vinodkone]

Github user vinodkone commented on the pull request:

https://github.com/apache/mesos/pull/93#issuecomment-204558214
  
libev is committed. You can rebase it now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] mesos pull request: Upgrade zookeeper to 3.4.8.

[chenzhiwei]

Github user chenzhiwei commented on the pull request:

https://github.com/apache/mesos/pull/93#issuecomment-204145852
  
I found I need to rebase again if the upgrade libev patch was submitted, so 
let's wait for libev patch to be submitted, then I will rebase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] mesos pull request: Upgrade zookeeper to 3.4.8.

[chenzhiwei]

Github user chenzhiwei commented on a diff in the pull request:

https://github.com/apache/mesos/pull/93#discussion_r58131254
  
--- Diff: 3rdparty/Makefile.am ---
@@ -51,7 +51,7 @@ EXTRA_DIST =  \
 EXTRA_DIST +=  \
   $(LEVELDB).patch
 
-# We need to patch ZooKeeper in order to get 3.4.5 to compile on
+# We need to patch ZooKeeper in order to get 3.4.8 to compile on
 # OS X 10.10. See: MESOS-1797.
--- End diff --

Thank your for pointing this, I will remove this comment. And for the 
zookeeper patch file I think I already removed it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] mesos pull request: Upgrade zookeeper to 3.4.8.

[vinodkone]

Github user vinodkone commented on a diff in the pull request:

https://github.com/apache/mesos/pull/93#discussion_r58094904
  
--- Diff: 3rdparty/Makefile.am ---
@@ -51,7 +51,7 @@ EXTRA_DIST =  \
 EXTRA_DIST +=  \
   $(LEVELDB).patch
 
-# We need to patch ZooKeeper in order to get 3.4.5 to compile on
+# We need to patch ZooKeeper in order to get 3.4.8 to compile on
 # OS X 10.10. See: MESOS-1797.
--- End diff --

Does this comment still apply? AFAICT MESOS-1797 doesn't apply to ZK 3.4.8 
since that issue has been resolved in ZK 3.4.7. Looks all the patch does is 
apply PPC specific fixes for which you already submitted a review 
https://reviews.apache.org/r/45376/.

I would recommend to kill the zookeper.patch stuff in this review 
altogether since 3.4.8 doesn't need any patches per se. Then in 
https://reviews.apache.org/r/45376/ you can add back the patch stuff and 
mention that you need the patch to compile it on PPC.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] mesos pull request: Upgrade zookeeper to 3.4.8.

[chenzhiwei]

GitHub user chenzhiwei opened a pull request:

https://github.com/apache/mesos/pull/93

Upgrade zookeeper to 3.4.8.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenzhiwei/mesos upgrade-zookeeper

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mesos/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #93


commit 944699052986ac9a2bbdae50e4149e75e3e3f17b
Author: Chen Zhiwei 
Date:   2016-03-28T06:48:23Z

Upgrade zookeeper to 3.4.8.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---