Re: Easing the Pain of Code Formatting in Mesos

2017-06-18 Thread tommy xiao
+1 2017-06-16 1:26 GMT+08:00 Greg Mann : > +1!!! > > On Thu, Jun 15, 2017 at 8:43 AM, Jie Yu wrote: > > > +1 > > > > Also, agreed with AlexR. Some of our style rules are very subjective. > > Tooling and enforceable rules are much more important. > > > >

Re: Easing the Pain of Code Formatting in Mesos

2017-06-15 Thread Greg Mann
+1!!! On Thu, Jun 15, 2017 at 8:43 AM, Jie Yu wrote: > +1 > > Also, agreed with AlexR. Some of our style rules are very subjective. > Tooling and enforceable rules are much more important. > > - Jie > > On Thu, Jun 15, 2017 at 8:13 AM, Zhitao Li

Re: Easing the Pain of Code Formatting in Mesos

2017-06-15 Thread Jie Yu
+1 Also, agreed with AlexR. Some of our style rules are very subjective. Tooling and enforceable rules are much more important. - Jie On Thu, Jun 15, 2017 at 8:13 AM, Zhitao Li wrote: > strongly +1 to this. > > On Thu, Jun 15, 2017 at 7:20 AM, Alex Rukletsov

Re: Easing the Pain of Code Formatting in Mesos

2017-06-15 Thread Zhitao Li
strongly +1 to this. On Thu, Jun 15, 2017 at 7:20 AM, Alex Rukletsov wrote: > +1. Having an enforceable rule is sometimes more important than the rule > itself (e.g., 4 vs. 2 spaces indent). > > On Thu, Jun 15, 2017 at 9:59 AM, Alexander Rojas >

Re: Easing the Pain of Code Formatting in Mesos

2017-06-15 Thread Alex Rukletsov
+1. Having an enforceable rule is sometimes more important than the rule itself (e.g., 4 vs. 2 spaces indent). On Thu, Jun 15, 2017 at 9:59 AM, Alexander Rojas wrote: > +1 It is always frustrating to rely in clang format to realize it generate > the wrong style, even

Re: Easing the Pain of Code Formatting in Mesos

2017-06-15 Thread Alexander Rojas
+1 It is always frustrating to rely in clang format to realize it generate the wrong style, even for old Mesos contributors Alexander Rojas alexan...@mesosphere.io > On 15. Jun 2017, at 04:32, Michael Park wrote: > > I'm increasingly hearing that many contributors who

Re: Easing the Pain of Code Formatting in Mesos

2017-06-14 Thread Silas Snider
I regret I have but one +1 to give, etc. > On Jun 14, 2017, at 7:32 PM, Michael Park wrote: > > I'm increasingly hearing that many contributors who want to contribute to > Mesos find that > it's often difficult to do so. One of the big issues is due to our > formatting rules

Easing the Pain of Code Formatting in Mesos

2017-06-14 Thread Michael Park
I'm increasingly hearing that many contributors who want to contribute to Mesos find that it's often difficult to do so. One of the big issues is due to our formatting rules which is not automated. As a result, we've had many reviews that are overwhelming in style comments with only a couple of