We do accept Pull-Requests https://github.com/apache/mesos/pulls for
small patches, especially (markdown) documentation patches; but for larger
code changes we prefer the issue tracking, multi-line comments, and
incremental diffs provided by ReviewBoard.
On Tue, Mar 31, 2015 at 10:55 AM, haosdent
Aditi,
for a single commit I use `git show sha patch.diff`.
I would encourage you to use rbt tools though. Your github tree should look
as follows before your run ./support/post-review.sh :
O [your branch], active, checked out
|
...
|
O [master] [upstream/master]
|
...
|
O
hope this
If it is possible, I suggest use the workflow like
https://github.com/apache/spark: Submit push request to github.
On Wed, Apr 1, 2015 at 1:49 AM, Vinod Kone vinodk...@apache.org wrote:
Are you still having issue with this?
I've seen this issue before when my branch depends on a file that was
Are you still having issue with this?
I've seen this issue before when my branch depends on a file that was
recently committed. The mesos repo used by ReviewBoard is a mirror of the
canonical mesos repo and there is sometimes lag in the commits from the
latter reaching the former. But the issue
Aditi,
Check your .reviewboardrc file. REVIEWBOARD_URL should point to
https://reviews.apache.org/, REPOSITORY should be mesos.
Hope this helps,
Alex
On 29/03/2015 3:56 pm, Aditi Dixit aditi96di...@gmail.com wrote:
Hi,
I'm trying to create a review request but running support/post_review.py
Also make sure your patch (branch) is on top of current master, rebase if
necessary. You can also manually upload the diff from ReviewBoard UI.
On 29/03/2015 6:02 pm, Alex Rukletsov a...@mesosphere.io wrote:
Aditi,
Check your .reviewboardrc file. REVIEWBOARD_URL should point to
Hi,
I'm trying to create a review request but running support/post_review.py
keeps failing with the following output :
Running 'rbt post' across all of ...
efe1191ea53347f193dddc962030047e5eb45e0b - (HEAD, MESOS-2564) [MESOS-2564]
Removed useless forward declaration comments (40 minutes ago)
Thanks for the response Alex.
I checked the .reviewboardrc file and its parameters were the same that you
mentioned. I had also taken care to rebase the so that my commit was over
the current master.
While trying to submit a patch manually through the ReviewBoard UI, I was
getting an error that
