Re: RFC: removing process implementations from common headers

Sounds good to me, I also like putting the internal limiter_process.hpp (if needed for testing) in the src folder (note that we already have internal headers there). Thanks James! Looking forward to having this tidied up. Let me know if you need any assistance wrangling reviewers :) On Wed, Jun 2

Re: RFC: removing process implementations from common headers

> On Jun 28, 2017, at 2:19 AM, Benjamin Mahler wrote: > > Thanks James! As you said, removing Process implementations from the > headers is the existing practice, but we need to do a sweep to enforce this > consistently. Folks could work on this sweep today to make progress on the > 3 benefits y

Re: RFC: removing process implementations from common headers

Thanks James! As you said, removing Process implementations from the headers is the existing practice, but we need to do a sweep to enforce this consistently. Folks could work on this sweep today to make progress on the 3 benefits you outlined. This proposal to me seems to just be: (1) When neede

Re: RFC: removing process implementations from common headers

I'm in favor of the suggestion. Do you guys plan to do a single sweep or document the pattern somewhere and apply it only for new and refactored code? On Wed, Jun 28, 2017 at 12:19 AM, Yan Xu wrote: > This sounds reasonable to me. Do others have comments? > > --- > @xujyan

Re: RFC: removing process implementations from common headers

This sounds reasonable to me. Do others have comments? --- @xujyan On Fri, Jun 23, 2017 at 4:23 PM, James Peach wrote: > Hi all, > > There is a common Mesos pattern where a subsystem is implemented by a > facade class that forwards calls to an internal Process class

RFC: removing process implementations from common headers

Hi all, There is a common Mesos pattern where a subsystem is implemented by a facade class that forwards calls to an internal Process class, eg. Fetcher and FetcherProcess, or zookeeper::Group and zookeeper::GroupProcess. Since the Process is an internal implementation detail, I'd like to propo