I also use apply-reviews as an aid for code reviewing. Glad to see others
are doing this since IMHO just looking at diffs rather than the final
product can be limiting.
On Thu, Nov 12, 2015 at 11:57 AM, Isabel Jimenez <
contact.isabeljime...@gmail.com> wrote:
> I also like to apply reviews,
I remember Jenkins could execute post-build task after build successfully,
maybe we could configure it as a post tasks in
https://builds.apache.org/job/Mesos/ ?
On Sun, Nov 15, 2015 at 11:50 PM, Alex Rukletsov
wrote:
> Another use case for apply-reviews is rebasing own
Another use case for apply-reviews is rebasing own changes on top of a
not-yet-committed chain (similar to Isabel's use case).
On Sun, Nov 15, 2015 at 4:44 PM, Benjamin Mahler
wrote:
> I also use apply-reviews as an aid for code reviewing. Glad to see others
> are
sounds good. so lets create a submit_reviews.py that calls into
apply_reviews.py. that way the former will only be useful for committers.
On Sun, Nov 15, 2015 at 7:50 AM, Alex Rukletsov wrote:
> Another use case for apply-reviews is rebasing own changes on top of a
>
Just a data point, I always apply reviews, not only to compile, but
also just because I like using my existing toolset to interact with
the code and understand it.
On Thu, Nov 12, 2015 at 12:59 AM, Artem Harutyunyan wrote:
> Interesting, I always thought that people apply,
I also like to apply reviews, specially when reviewbot hasn't got to that
review yet. My guess is that apply-reviews is also used when people are
asking for new features progress or bug fixes that haven't been merged yet.
On Thu, Nov 12, 2015 at 11:42 AM, Alex Clemmer
Interesting, I always thought that people apply, compile and try out
patches locally before giving them a 'Ship It'.
Regarding pushing the code, I don't have enough of context, so could you
please create a JIRA if you still think that it'd be great to have that
feature added to the script?
On
AFAIK, apply-reviews is used mainly by committers. Maybe some one can use
to locally test a review chain of somebody else, but that is pretty rare.
Regarding having apply-reviews to automatically push commits to the repo,
we need to figure out the credentials delegation aspect. Ideally, it would
That said, this can be automated as a step in apply-reviews script. For
example, the script can check if something in site/ (or docs/ ?) is being
committed and if yes, also do an svn update. @artem do you want to take
this on as you revamp the apply-reviews script?
On Tue, Nov 10, 2015 at 1:23
Does anyone know how frequently the docs at mesos.apache.org are
updated? I notice that some docs changes from > 1 week ago aren't
reflected on the current site.
Neil
Since it's still a manual process, the website is usually only updated a)
when we have a new release to announce, or b) when some other blog-worthy
content arises (e.g. MesosCon).
On Tue, Nov 10, 2015 at 1:06 AM, Jonathon Rossi wrote:
> It is currently a manual process
It is currently a manual process performed by a committer, however there
are plans to make it automated. See this thread for the recent discussion:
http://www.mail-archive.com/dev@mesos.apache.org/msg33541.html
On Tue, Nov 10, 2015 at 6:56 PM, Neil Conway wrote:
> Does
I think we could consider generate the document realtime. Like
http://netty.io/wiki/index.html Loading the markdown from their github wiki
repo and generate html in browser. I write some simple javascript to
implement this several months ago.
You are obviously free to implement this as you wish, however one of the
things we realised is that the hosted API docs on the web site are also
very out of date, and by doing it this way would mean they stay out of
date. Doing it this way means you would really have to update on every
commit, or
We've also still got this one open that I intended would take us right
through to the automatic site build:
https://issues.apache.org/jira/browse/MESOS-3687
On Wed, Nov 11, 2015 at 5:00 PM, Artem Harutyunyan
wrote:
> Hey Vinod,
>
> Here is the JIRA
Hey Vinod,
Here is the JIRA https://issues.apache.org/jira/browse/MESOS-3883.
I don't mean to hijack this thread, and I apologize for the off-topic, but
do you think it would make sense to have another script for committers that
will use apply-reviews.py? At some point you also mentioned that it
The JavaDoc on the Netty page looks like static HTML. However I see the
other docs loading from the wiki.
Loading the Mesos markdown files looks pretty nice and simple using marked,
however I assume that'll lock Google Search out of content and change all
the URLs?
On Wed, Nov 11, 2015 at 12:43
google crawlers support execute javascript. Netty.io looks generate in
server side now.
On Wed, Nov 11, 2015 at 11:36 AM, Jonathon Rossi wrote:
> The JavaDoc on the Netty page looks like static HTML. However I see the
> other docs loading from the wiki.
>
> Loading the Mesos
After a quick google search you are definitely right, I knew google did but
they've definitely innovated in the last few years.
Is there any tools to do the same for Doxygen and javadoc?
On Wed, Nov 11, 2015 at 1:49 PM, haosdent wrote:
> google crawlers support execute
19 matches
Mail list logo