Re: Why rely on url scheme for fetching?

2014-11-04 Thread Bernd Mathiske
Hi Ankur, I like it, too. However, I cannot refrain from relaying (not my choice of word here) to you the advice to break your relatively large patch down into smaller parts. My patch for MESOS-336 certainly was, as I know now. My plan is to get MESOS-1316 (which is now under review) and

Re: Why rely on url scheme for fetching?

2014-11-04 Thread Bernd Mathiske
Typo: not - note On Nov 4, 2014, at 10:59 AM, Bernd Mathiske be...@mesosphere.io wrote: Hi Ankur, I like it, too. However, I cannot refrain from relaying (not my choice of word here) to you the advice to break your relatively large patch down into smaller parts. My patch for MESOS-336

Re: Why rely on url scheme for fetching?

2014-11-04 Thread Ankur Chauhan
Hi ben, Thanks for the follow up. I think thats a perfectly fine game plan. I think I can break down things into smaller, more isolated chunks. But from the looks of MESOS-1316 the invocation code and the testing code seems to change a lot (in a good way), so to avoid a bunch of wasted cycles,

Re: Why rely on url scheme for fetching?

2014-11-04 Thread Bernd Mathiske
Hi Ankur, I am Bernd, not Ben, but I’ll try to do my best :-) Your plan looks good to me and your patch for MESOS-1711 seems uncomplicated enough to not cause me major problems no matter when it lands. Bernd On Nov 4, 2014, at 11:44 AM, Ankur Chauhan an...@malloc64.com wrote: Hi ben,

Re: Why rely on url scheme for fetching?

2014-11-04 Thread Ankur Chauhan
Hi, Sorry about that bernd! :s/ben/bernd/g -- ankur Sent from my iPhone On Nov 4, 2014, at 3:13 AM, Bernd Mathiske be...@mesosphere.io wrote: Hi Ankur, I am Bernd, not Ben, but I’ll try to do my best :-) Your plan looks good to me and your patch for MESOS-1711 seems uncomplicated

Re: Why rely on url scheme for fetching?

2014-11-04 Thread Bernd Mathiske
No problem. We non-English folks have complicated names :-) On Nov 4, 2014, at 12:51 PM, Ankur Chauhan an...@malloc64.com wrote: Hi, Sorry about that bernd! :s/ben/bernd/g -- ankur Sent from my iPhone On Nov 4, 2014, at 3:13 AM, Bernd Mathiske be...@mesosphere.io wrote: Hi Ankur,

Re: Why rely on url scheme for fetching?

2014-11-03 Thread Dominic Hamon
Hi Ankur I think this is a great approach. It makes the code much simpler, extensible, and more testable. Anyone that's heard me rant knows I am a big fan of unit tests over integration tests, so this shouldn't surprise anyone :) If you haven't already, please read the documentation on

Re: Why rely on url scheme for fetching?

2014-11-03 Thread Adam Bordelon
+ Bernd, who has done some fetcher work, including additional testing, for MESOS-1316, MESOS-1945, and MESOS-336 On Mon, Nov 3, 2014 at 9:04 AM, Dominic Hamon dha...@twopensource.com wrote: Hi Ankur I think this is a great approach. It makes the code much simpler, extensible, and more

Re: Why rely on url scheme for fetching?

2014-11-03 Thread Ankur Chauhan
Yea, I saw those today morning. I'll hold off a little mesos-336 changes a lot of stuff. Sent from my iPhone On Nov 3, 2014, at 9:18 AM, Adam Bordelon a...@mesosphere.io wrote: + Bernd, who has done some fetcher work, including additional testing, for MESOS-1316, MESOS-1945, and

Re: Why rely on url scheme for fetching?

2014-11-03 Thread Ankur Chauhan
Hi Tim/others, Is this to be included in the 0.21.0 release? If so, I don't know how to tag it etc. I would really (shamelessly) love it to be included as it would really simplify my intended usecase of using snackfs (cassandra backed filesystem). -- Ankur On 3 Nov 2014, at 09:28, Ankur

Re: Why rely on url scheme for fetching?

2014-11-03 Thread Ian Downes
Unfortunately, this will not get in 0.21.0 as we're tagging that today. Please tag the ticket(s) as Target Version = 0.22.0. Ian On Mon, Nov 3, 2014 at 10:22 AM, Ankur Chauhan an...@malloc64.com wrote: Hi Tim/others, Is this to be included in the 0.21.0 release? If so, I don't know how to

Re: Why rely on url scheme for fetching?

2014-11-03 Thread Ankur Chauhan
Hi, Okay, thanks Ian. What's the expected ETA on getting 0.21.0 out? jira didn't have a release date set. -- Ankur On 3 Nov 2014, at 10:37, Ian Downes idow...@twitter.com.INVALID wrote: Unfortunately, this will not get in 0.21.0 as we're tagging that today. Please tag the ticket(s) as

Re: Why rely on url scheme for fetching?

2014-11-03 Thread Timothy Chen
I think it's too late to be included, since it's going to take some rounds of review, and Ian is cutting the release today. We'll have to tag this for the next release. Tim On Mon, Nov 3, 2014 at 10:22 AM, Ankur Chauhan an...@malloc64.com wrote: Hi Tim/others, Is this to be included in the

Re: Why rely on url scheme for fetching?

2014-11-03 Thread Ankur Chauhan
That's cool. I think if it gets reviews and gets an okay I'll modify my deployment and build myself some deb packages with these changes till 0.22.0 ships. Sent from my iPhone On Nov 3, 2014, at 12:49 PM, Timothy Chen tnac...@gmail.com wrote: I think it's too late to be included, since