Github user kaspersorensen closed the pull request at:
https://github.com/apache/metamodel/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/159
METAMODEL-1160 and METAMODEL-1163: Deserialization of legacy schema objects
Fixes both METAMODEL-1160 and METAMODEL-1163.
You can merge this pull request into a Git repository by running:
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tomatophantastico commented on the issue:
https://github.com/apache/metamodel/pull/158
I found those "toString" test to be quite problematic too, even in small
tests and i encountered a lot of them during the arrays->collection conversion
and i would be happy to see them
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/158
Unfocused tests also has the problem that it's often unclear what it
intends to test, it makes it harder to understand what the purpose of the code
it is testing was, making its value as part of
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/158
Actually, that's one of the worst kind for me (in general, but especially
in this context), since they assume order, and often lead to unfocused tests
(e.g. testing the whole list instead of that
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/158
Please merge, but also remember to add an entry in CHANGES.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/158
Ok, I think you have committer rights to prepare a 4.6.1 release branch
with the fix then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/158
Nope, only the version you're maintaining. We have no update plans until
next major release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/158
Code LGTM. So we can merge.
As for a release, I looked at DataCleaner and haven't you actually upgraded
to some 5.0 RC version? Not the latest with the big arrays-to-collections
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/158
BTW, any chance that we could also add this to a 4.x bugfix release? In
DataCleaner we'll soon make a bugfix release, and moving to 5.x for that seems
like a quite a change
---
If your project is
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/158
Whoops, missed the query rewriter tests. Will fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user LosD opened a pull request:
https://github.com/apache/metamodel/pull/158
METAMODEL-1161: Max rows without offset and order by
This fixes Oracle and SQL Server max rows and offset to work properly in
all viable situations, and to use post processing otherwise.
13 matches
Mail list logo
