[GitHub] metamodel issue #179: Feature/neo4j column types

2018-05-28 Thread jhorcicka
Github user jhorcicka commented on the issue: https://github.com/apache/metamodel/pull/179 @arjansh, @kaspersorensen: Updated. I plan to create another PR to fix some code style issues like missing "final" keywords after this one is accepted. ---

[GitHub] metamodel pull request #179: Feature/neo4j column types

2018-05-28 Thread jhorcicka
Github user jhorcicka commented on a diff in the pull request: https://github.com/apache/metamodel/pull/179#discussion_r191188566 --- Diff: neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java --- @@ -0,0 +1,126 @@ +/** + * Licensed to the Apache

[GitHub] metamodel pull request #179: Feature/neo4j column types

2018-05-28 Thread jhorcicka
Github user jhorcicka commented on a diff in the pull request: https://github.com/apache/metamodel/pull/179#discussion_r191154706 --- Diff: neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java --- @@ -0,0 +1,126 @@ +/** + * Licensed to the Apache

[GitHub] metamodel pull request #179: Feature/neo4j column types

2018-05-28 Thread jhorcicka
Github user jhorcicka commented on a diff in the pull request: https://github.com/apache/metamodel/pull/179#discussion_r191153847 --- Diff: neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java --- @@ -0,0 +1,126 @@ +/** + * Licensed to the Apache