Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/83
Added fix for escaping in CsvWriter in case where quote char is not set
Today I discovered a small bug in MetaModel's CsvWriter - that it would
fail to escape a separator char if there is
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/83#discussion_r47944152
--- Diff: csv/src/main/java/org/apache/metamodel/csv/CsvWriter.java ---
@@ -72,23 +72,38 @@ public String buildLine(String[] nextLine) {
}
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/83#discussion_r47943210
--- Diff: csv/src/main/java/org/apache/metamodel/csv/CsvWriter.java ---
@@ -72,23 +72,38 @@ public String buildLine(String[] nextLine) {
}
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/83#discussion_r47951295
--- Diff: csv/src/main/java/org/apache/metamodel/csv/CsvWriter.java ---
@@ -72,23 +72,38 @@ public String buildLine(String[] nextLine) {
}
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/83#discussion_r47951195
--- Diff: csv/src/main/java/org/apache/metamodel/csv/CsvWriter.java ---
@@ -72,23 +72,38 @@ public String buildLine(String[] nextLine) {
}
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/83#issuecomment-165548619
Except for the weird ```stringContainsSpecialCharacters```, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/83#discussion_r47951019
--- Diff: csv/src/main/java/org/apache/metamodel/csv/CsvWriter.java ---
@@ -72,23 +72,38 @@ public String buildLine(String[] nextLine) {
}
